-
Notifications
You must be signed in to change notification settings - Fork 4k
Updated with a link to geographic regions #4131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dilukose, |
Can one of the admins verify this patch? |
@azuresdkci add to whitelist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dilukose one quick comment
@@ -105,7 +105,7 @@ Accept wildcard characters: False | |||
``` | |||
|
|||
### -GeoMapping | |||
The list of regions mapped to this endpoint when using the 'Geographic' traffic routing method. Please consult Traffic Manager documentation for a full list of accepted values. | |||
The list of regions mapped to this endpoint when using the 'Geographic' traffic routing method. Please consult Traffic Manager documentation for a [full list of accepted values] (https://docs.microsoft.com/en-us/azure/traffic-manager/traffic-manager-geographic-regions). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dilukose the space between the ending square bracket and opening parenthesis is causing the markdown to not get rendered correctly:
[full list of accepted values] (https://docs.microsoft.com/en-us/azure/traffic-manager/traffic-manager-geographic-regions)
vs.
@dilukose ping |
@dilukose I went ahead and made the change I mentioned above in the review (since it seems that was your intention). This can be merged once CI is finished. |
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines