New property of the express route resources #4195
Conversation
There was a problem hiding this comment.
@dihan0604 once SDK is merged, only then this can be sent for PR.
| @@ -104,5 +106,11 @@ public class AzureExpressRouteCircuitPeeringConfigBase : NetworkBaseCmdlet | |||
| HelpMessage = "RouteFilter")] | |||
| [ValidateNotNullOrEmpty] | |||
| public PSRouteFilter RouteFilter { get; set; } | |||
|
|
|||
| [Parameter( | |||
There was a problem hiding this comment.
@dihan0604 please add tests for this new parameter.
| @@ -72,4 +74,10 @@ public override void Execute() | |||
| WriteObject(peering); | |||
| } | |||
| } | |||
|
|
|||
| public enum LegacyMode | |||
There was a problem hiding this comment.
@dihan0604 please use the link to update help for the new parameter
https://github.com/Azure/azure-powershell/blob/preview/documentation/help-generation.md
| Mandatory = false, | ||
| ValueFromPipelineByPropertyName = true, | ||
| HelpMessage = "The legacy mode of the Peering")] | ||
| public LegacyMode LegacyMode { get; set; } |
There was a problem hiding this comment.
@dihan0604 can you explain the reasoning behind introducing an enum that has True and False values? Why can't we just use a boolean to express this parameter?
| @@ -41,7 +41,7 @@ public override void Execute() | |||
| this.ExpressRouteCircuit.Peerings.First( | |||
| resource => | |||
| string.Equals(resource.Name, this.Name, System.StringComparison.CurrentCultureIgnoreCase)); | |||
|
|
|||
There was a problem hiding this comment.
@dihan0604 revert this change please
|
@dihan0604 Did you published required nuget packages that you need for Powershell? |
|
comment addressed and tests added |
|
On demand passed: http://azuresdkci.cloudapp.net/job/powershell-demand/1721/ |
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcessand haveSupportShouldProcess=truespecified in the cmdlet attribute. You can find more information onShouldProcesshere.OutputTypeattribute if any output is produced - if the cmdlet produces no output, it should implement aPassThruparameter.Cmdlet Parameter Guidelines