Skip to content

Fix bugs and disable 'Remove-AzureRmServiceFabricNodeType' #4211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2017

Conversation

QingChenmsft
Copy link
Contributor

@QingChenmsft QingChenmsft commented Jun 28, 2017

Description

Please add an informative description that covers the changes made by the pull request.

  1. fix naming issue for key vault/ certificate/ storage
  2. Disable Remove-AzureRmServiceFabricNodeType for now, since our production doesn't support this operation now, we maybe enable this later(1 month or 2 month after we fix the issue)

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

@msftclas
Copy link

@QingChenmsft,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

'Get-AzureRmServiceFabricCluster',
'New-AzureRmServiceFabricCluster',
'Remove-AzureRmServiceFabricClientCertificate',
'Remove-AzureRmServiceFabricClusterCertificate',
'Remove-AzureRmServiceFabricNode',
'Remove-AzureRmServiceFabricNodeType',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@QingChenmsft ok this will not be possible. Any reasons you want to remove this cmdlet?
Please add detailed explanation in description as to why are you removing this cmdlet?
Also someone can still import binary module (.dll) and can still use your cmdlet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added, i have disabled build this .cs file too, so user can't use it even import the binary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@QingChenmsft you cannot remove stuff once it's shipped?
Can you please explain what you mean by our production does not support this operation? Was it ever supported? If yes why it does not support it anymore without following proper deprecation process.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the recommend way to disable/remove the command , we have bug which can't be fix easily now, so we need more time to fix it , so we can enable this command again.

Copy link
Contributor

@shahabhijeet shahabhijeet Jun 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@QingChenmsft add a warning or error for the user that gives them enough information not to use this cmdlet.

@shahabhijeet
Copy link
Contributor

shahabhijeet commented Jun 29, 2017

Once CI and on-demand pass, this is good to go.
On-Demand http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1717/

@shahabhijeet shahabhijeet merged commit caa42b0 into Azure:preview Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants