-
Notifications
You must be signed in to change notification settings - Fork 4k
Fix bugs and disable 'Remove-AzureRmServiceFabricNodeType' #4211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@QingChenmsft, |
'Get-AzureRmServiceFabricCluster', | ||
'New-AzureRmServiceFabricCluster', | ||
'Remove-AzureRmServiceFabricClientCertificate', | ||
'Remove-AzureRmServiceFabricClusterCertificate', | ||
'Remove-AzureRmServiceFabricNode', | ||
'Remove-AzureRmServiceFabricNodeType', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@QingChenmsft ok this will not be possible. Any reasons you want to remove this cmdlet?
Please add detailed explanation in description as to why are you removing this cmdlet?
Also someone can still import binary module (.dll) and can still use your cmdlet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added, i have disabled build this .cs file too, so user can't use it even import the binary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@QingChenmsft you cannot remove stuff once it's shipped?
Can you please explain what you mean by our production does not support this operation? Was it ever supported? If yes why it does not support it anymore without following proper deprecation process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the recommend way to disable/remove the command , we have bug which can't be fix easily now, so we need more time to fix it , so we can enable this command again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@QingChenmsft add a warning or error for the user that gives them enough information not to use this cmdlet.
Once CI and on-demand pass, this is good to go. |
Description
Please add an informative description that covers the changes made by the pull request.
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines