-
Notifications
You must be signed in to change notification settings - Fork 4k
Adding vmss networking tests #4292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@EvgenyAgafonchikov, |
1744b27
to
32c14ff
Compare
try | ||
{ | ||
# Common | ||
$loc = 'southeastasia'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not hardcode the location. This prevents this test from being used with subscriptiosn that do not have access there, or in environments that do not have this location. Instead, query ARM for the available locations for the providers thaty are needed for this test. You can prefer a location if it appears in the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
32c14ff
to
89f0833
Compare
LGTM |
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines