EventHub: RP version 2017-04-01 and cmdlet recommendations #4307

v-Ajnava · 2017-07-13T04:48:09Z

Description

PR consist the changes related RP version 2017-04-01 and cmdlet recommendations from PowerShell review team.

RP version changes changes included 3 properties are marked as Obsolete and few properties added.
Recommendations include the 6 Namespace authorization rule cmdlet marked as Obsolete and

Updated Eventhub authorization rule cmdlet with Parameter sets to differentiate the authorization rule for Namespace and Eventhub.

renamed cmdlet parameters with recommended and added old names as alias.

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

I have read the contribution guidelines.
If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

Pull request includes test coverage for the included changes.
PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

markcowl · 2017-07-15T00:08:07Z

@v-Ajnava Test failures, please take a look

markcowl · 2017-07-15T00:05:06Z

NuGet.config

@@ -1,9 +1,14 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>


Please do not change this

markcowl · 2017-07-21T02:10:21Z

setup/azurecmdfiles.wxi

@@ -2,6 +2,12 @@
 <Include xmlns="http://schemas.microsoft.com/wix/2006/wi">
    <Fragment>
        <DirectoryRef Id="PowerShellFolder">


why are you changing this file? None of these changes are valid

markcowl · 2017-07-21T02:14:03Z

...ventHub/Commands.EventHub/Cmdlets/AuthorizationRule/RemoveAzureEventhubAuthorizationRules.cs

+    /// 'Remove-AzureRmRelayAuthorizationRule' Cmdlet removes/deletes AuthorizationRule
+    /// </summary>
+    [Cmdlet(VerbsCommon.Remove, EventHubAuthorizationRuleVerb, DefaultParameterSetName = NamespaceAuthoRuleParameterSet, SupportsShouldProcess = true), OutputType(typeof(bool))]
+    public class RemoveAzureRelayAuthorizationRule : AzureEventHubsCmdletBase


class name should match file name

@v-Ajnava ^ ping on this comment

markcowl · 2017-07-21T02:14:16Z

src/ResourceManager/EventHub/Commands.EventHub/Cmdlets/AuthorizationRule/NewAzureEventhubKey.cs

+    /// 'New-AzureRmRelayKey' Cmdlet creates a new specified (PrimaryKey / SecondaryKey) key for the given WcfRelay Authorization Rule
+    /// </summary>
+    [Cmdlet(VerbsCommon.New, EventHubKeyVerb, DefaultParameterSetName = NamespaceAuthoRuleParameterSet, SupportsShouldProcess = true), OutputType(typeof(AuthorizationRuleKeysAttributes))]
+    public class NewAzureRmRelayKey : AzureEventHubsCmdletBase


class name should match file name

markcowl · 2017-07-21T02:14:30Z

...r/EventHub/Commands.EventHub/Cmdlets/AuthorizationRule/NewAzureEventhubAuthorizationRules.cs

+    /// 'New-AzureRmRelayAuthorizationRule' Cmdlet creates a new AuthorizationRule
+    /// </summary>
+    [Cmdlet(VerbsCommon.New, EventHubAuthorizationRuleVerb, DefaultParameterSetName = NamespaceAuthoRuleParameterSet, SupportsShouldProcess = true), OutputType(typeof(AuthorizationRuleAttributes))]
+    public class NewAzureRelayAuthorizationRule : AzureEventHubsCmdletBase


class name shoudl match file name

markcowl · 2017-07-21T02:14:54Z

...r/EventHub/Commands.EventHub/Cmdlets/AuthorizationRule/SetAzureEventhubAuthorizationRules.cs

+    /// 'Set-AzureRmRelayAuthorizationRule' Cmdlet updates the specified AuthorizationRule
+    /// </summary>
+    [Cmdlet(VerbsCommon.Set, EventHubAuthorizationRuleVerb, DefaultParameterSetName = NamespaceAuthoRuleParameterSet, SupportsShouldProcess = true), OutputType(typeof(AuthorizationRuleAttributes))]
+    public class SetAzureRelayAuthorizationRule : AzureEventHubsCmdletBase


markcowl · 2017-07-21T02:20:02Z

src/ResourceManager/IotHub/Commands.IotHub.Test/packages.config

  <package id="Microsoft.Azure.Management.IotHub" version="1.1.2" targetFramework="net452" />
  <package id="Microsoft.Azure.Management.Resources" version="2.20.0-preview" targetFramework="net45" />
  <package id="Microsoft.Azure.Test.Framework" version="1.0.6179.26854-prerelease" targetFramework="net45" />
-  <package id="Microsoft.Azure.Test.HttpRecorder" version="1.6.7-preview" targetFramework="net45" />
+  <package id="Microsoft.Azure.Test.HttpRecorder" version="1.7.0" targetFramework="net452" />


why is this updated?

markcowl · 2017-07-21T02:20:14Z

src/ResourceManager/IotHub/Commands.IotHub.Test/ScenarioTests/IotHubTests.ps1

@@ -38,7 +38,7 @@ function Test-AzureRmIotHubLifecycle
 	$resourceGroup = New-AzureRmResourceGroup -Name $ResourceGroupName -Location $Location 

 	Write-Debug " Create new eventHub " 
-	$namespaceName = "IotHubPSEHNamespaceTest"
+	$namespaceName = "IotHubPSEHNamespaceTest1212"


why is this updated?

markcowl · 2017-07-21T02:22:18Z

tools/StaticAnalysis/Exceptions/BreakingChangeIssues.csv

+"D:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.EventHub\Microsoft.Azure.Commands.EventHub.dll","Microsoft.Azure.Commands.EventHub.Commands.EventHub.GetAzureRmEventHubAuthorizationRule","Get-AzureRmEventHubAuthorizationRule","0","2100","The parameter 'EventHubName' in cmdlet 'Get-AzureRmEventHubAuthorizationRule' is no longer in the parameter set '__AllParameterSets'.","Add parameter 'EventHubName' back to the parameter set '__AllParameterSets'."
+"D:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.EventHub\Microsoft.Azure.Commands.EventHub.dll","Microsoft.Azure.Commands.EventHub.Commands.EventHub.GetAzureEventHubKey","Get-AzureRmEventHubKey","0","1020","The cmdlet 'Get-AzureRmEventHubKey' no longer has output type 'Microsoft.Azure.Commands.EventHub.Models.ListKeysAttributes'.","Make cmdlet 'Get-AzureRmEventHubKey' return type 'Microsoft.Azure.Commands.EventHub.Models.ListKeysAttributes'."
+"D:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.EventHub\Microsoft.Azure.Commands.EventHub.dll","Microsoft.Azure.Commands.EventHub.Commands.EventHub.GetAzureEventHubKey","Get-AzureRmEventHubKey","0","2100","The parameter 'NamespaceName' in cmdlet 'Get-AzureRmEventHubKey' is no longer in the parameter set '__AllParameterSets'.","Add parameter 'NamespaceName' back to the parameter set '__AllParameterSets'."


Many of these look like actual breaking changes, which won't be accepted (for example, adding validation that wasn't ehere before)

v-Ajnava · 2017-07-25T17:11:16Z

@markcowl , for IoT Hub test case failure, we synced with Iot Hub team @rmanda made the changes.

cormacpayne · 2017-07-25T18:06:25Z

@v-Ajnava it looks like this PR is out of sync with the preview branch and is reverting a lot of merged changes. Please pull the latest changes from the preview branch.

cormacpayne

@v-Ajnava some comments that need to be resolved

cormacpayne · 2017-07-26T19:47:24Z

src/ResourceManager/EventHub/ChangeLog.md

@@ -19,7 +19,26 @@
 -->
 ## Current Release

-## Version 0.4.2
+## Version 4.3.0


@v-Ajnava please move the content below to under the Current Release header, and revert the changes made to Version 0.4.2 header

cormacpayne · 2017-07-26T19:48:05Z

src/ResourceManager/EventHub/Commands.EventHub.Test/ScenarioTests/ConsumerGroupsTests.ps1

+	Write-Debug "  Create new Evnethub namespace"
+    Write-Debug " Namespace name : $namespaceName"
+    $result = New-AzureRmEventHubNamespace -ResourceGroup $resourceGroupName -Name $namespaceName -Location $location
+    Wait-Seconds 15


@v-Ajnava why is this Wait-Seconds command needed?

Removed the wait command, used it for testing

not removed

cormacpayne · 2017-07-26T19:48:25Z

src/ResourceManager/EventHub/Commands.EventHub.Test/ScenarioTests/NamespaceTests.ps1

+    Write-Debug "Namespace name : $namespaceName"
+
+    $result = New-AzureRmEventHubNamespace -ResourceGroup $resourceGroupName -Name $namespaceName -Location $location
+    Wait-Seconds 15


@v-Ajnava same comment

Removed the wait command, used it for testing

Not removed

cormacpayne · 2017-07-26T19:51:42Z

...r/EventHub/Commands.EventHub/Cmdlets/AuthorizationRule/NewAzureEventhubAuthorizationRules.cs

+            ValueFromPipelineByPropertyName = true,
+            HelpMessage = "Rights, e.g.  \"Listen\",\"Send\",\"Manage\"")]
+        [ValidateNotNullOrEmpty]
+        public string[] Rights { get; set; }


@v-Ajnava consider using ValidateSet if the values that you can provide for this parameter are restricted to a set of strings

added validate set

cormacpayne · 2017-07-26T19:52:59Z

...ventHub/Commands.EventHub/Cmdlets/AuthorizationRule/RemoveAzureEventhubAuthorizationRules.cs

+    /// 'Remove-AzureRmRelayAuthorizationRule' Cmdlet removes/deletes AuthorizationRule
+    /// </summary>
+    [Cmdlet(VerbsCommon.Remove, EventHubAuthorizationRuleVerb, DefaultParameterSetName = NamespaceAuthoRuleParameterSet, SupportsShouldProcess = true), OutputType(typeof(bool))]
+    public class RemoveAzureRelayAuthorizationRule : AzureEventHubsCmdletBase


@v-Ajnava ^ ping on this comment

cormacpayne · 2017-07-26T19:56:32Z

src/ResourceManager/EventHub/Commands.EventHub/Cmdlets/EventHub/NewAzureEventHub.cs

        public string Location { get; set; }

        [Parameter(Mandatory = true,
            ValueFromPipelineByPropertyName = true,
-            Position = 3,
+            Position = 2,


@v-Ajnava why was this change made? You now have two parameters with the same position, which will cause an error

Reverted, by mistake

cormacpayne · 2017-07-26T19:57:17Z

.../EventHub/Commands.EventHub/Cmdlets/Namespace/GetAzureEventHubNamespaceAuthorizationRules.cs

@@ -51,6 +53,7 @@ public class GetAzureEventHubNamespaceAuthorizationRule : AzureEventHubsCmdletBa

        public override void ExecuteCmdlet()
        {
+           // WriteWarning("'Get-AzureRmEventHubNamespaceAuthorizationRule' cmdlet is mark as obsolete and will be depricated in upcoming breaking changes build. Please use the New cmdlet 'Get-AzureRmEventHubAuthorizationRule'");


@v-Ajnava please remove this line if it's going to be commented out

cormacpayne · 2017-07-26T19:58:18Z

src/ResourceManager/EventHub/Commands.EventHub/Cmdlets/Namespace/NewAzureEventHubNamespace.cs

+            Mandatory = false,
+            ValueFromPipelineByPropertyName = true,
+            HelpMessage = "Upper limit of throughput units when AutoInflate is enabled, vaule should be within 0 to 20 throughput units.")]
+        public int? MaximumThroughputUnits { get; set; }


@v-Ajnava please use ValidateSet if you're going to limit the value to be between 0-20

Also, there is a typo in the above HelpMessage: vaule should be value

For Validation I have used validate range.

cormacpayne · 2017-07-26T19:58:53Z

src/ResourceManager/EventHub/Commands.EventHub/Cmdlets/Namespace/NewAzureEventHubNamespace.cs

+        [Parameter(
+            Mandatory = false,
+            ValueFromPipelineByPropertyName = true,
+            HelpMessage = "Upper limit of throughput units when AutoInflate is enabled, vaule should be within 0 to 20 throughput units.")]


@v-Ajnava what happens when this value is provided but AutoInflate is disabled?

when AutoInflate is disabled and try to set MaximumThroughputUnits is been, RP will return an error

cormacpayne · 2017-07-26T19:59:32Z

src/ResourceManager/EventHub/Commands.EventHub/Cmdlets/Namespace/SetAzureEventHubNamespace.cs

+            Mandatory = false,
+            ValueFromPipelineByPropertyName = true,
+            HelpMessage = "Upper limit of throughput units when AutoInflate is enabled, vaule should be within 0 to 20 throughput units.")]
+        public int? MaximumThroughputUnits { get; set; }


@v-Ajnava same comments about ValidateSet, typo, and AutoInflate being disabled

when AutoInflate is disabled and try to set MaximumThroughputUnits is been, RP will return an error. For Validation I have used validate range.

markcowl · 2017-07-31T03:13:07Z

@v-Ajnava This cmdlet is out of sync with the preview branch. Please merge - also, since you already have multiple merge commits, please clean up your commits.

cormacpayne · 2017-08-03T17:53:34Z

On-demand: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1801/

…nto EHpwr2017

cormacpayne · 2017-08-04T17:58:26Z

src/ResourceManager/EventHub/Commands.EventHub/help/Set-AzureRmEventHubNamespace.md

@@ -9,16 +9,22 @@ schema: 2.0.0
 ## SYNOPSIS
 Updates the specified Event Hubs namespace.

-## SYNTAX


@v-Ajnava the ## SYNTAX header should not have been removed

corrected the markdown

cormacpayne · 2017-08-04T22:01:37Z

On-demand: http://azuresdkci.cloudapp.net/job/powershell-demand/1816/

cormacpayne · 2017-08-05T00:16:58Z

@azuresdkci test this please

markcowl · 2017-08-05T02:05:47Z

tools/StaticAnalysis/Exceptions/BreakingChangeIssues.csv

@@ -218,6 +218,38 @@
 "D:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.Network\Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.NewAzureLocalNetworkGatewayCommand","New-AzureRmLocalNetworkGateway","0","2020","The cmdlet 'New-AzureRmLocalNetworkGateway' no longer supports the type 'System.UInt32' for parameter 'Asn'.","Change the type for parameter 'Asn' back to 'System.UInt32'."
 "D:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.Network\Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.SetAzureLocalNetworkGatewayCommand","Set-AzureRmLocalNetworkGateway","0","2020","The cmdlet 'Set-AzureRmLocalNetworkGateway' no longer supports the type 'System.UInt32' for parameter 'Asn'.","Change the type for parameter 'Asn' back to 'System.UInt32'."
 "D:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.Network\Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.ResetAzureVirtualNetworkGatewayConnectionSharedKeyCommand","Reset-AzureRmVirtualNetworkGatewayConnectionSharedKey","0","2020","The cmdlet 'Reset-AzureRmVirtualNetworkGatewayConnectionSharedKey' no longer supports the type 'System.UInt32' for parameter 'KeyLength'.","Change the type for parameter 'KeyLength' back to 'System.UInt32'."
+"D:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.EventHub\Microsoft.Azure.Commands.EventHub.dll","Microsoft.Azure.Commands.EventHub.Commands.Namespace.NewAzureRmEventHubKey","New-AzureRmEventHubKey","0","2000","The cmdlet 'New-AzureRmEventHubKey' no longer supports the parameter 'ResourceGroup' and no alias was found for the original parameter name.","Add the parameter 'ResourceGroup' back to the cmdlet 'New-AzureRmEventHubKey', or add an alias to the original parameter name."


You should leave in an alias to ResourceGroup

Removed the exception, alias was added.

markcowl · 2017-08-05T02:07:08Z

tools/StaticAnalysis/Exceptions/BreakingChangeIssues.csv

+"D:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.EventHub\Microsoft.Azure.Commands.EventHub.dll","Microsoft.Azure.Commands.EventHub.Commands.Namespace.NewAzureEventHubNamespace","New-AzureRmEventHubNamespace","0","2100","The parameter 'SkuName' in cmdlet 'New-AzureRmEventHubNamespace' is no longer in the parameter set '__AllParameterSets'.","Add parameter 'SkuName' back to the parameter set '__AllParameterSets'."
+"D:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.EventHub\Microsoft.Azure.Commands.EventHub.dll","Microsoft.Azure.Commands.EventHub.Commands.Namespace.NewAzureEventHubNamespace","New-AzureRmEventHubNamespace","0","2100","The parameter 'SkuCapacity' in cmdlet 'New-AzureRmEventHubNamespace' is no longer in the parameter set '__AllParameterSets'.","Add parameter 'SkuCapacity' back to the parameter set '__AllParameterSets'."
+"D:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.EventHub\Microsoft.Azure.Commands.EventHub.dll","Microsoft.Azure.Commands.EventHub.Commands.Namespace.NewAzureEventHubNamespace","New-AzureRmEventHubNamespace","0","2100","The parameter 'Tag' in cmdlet 'New-AzureRmEventHubNamespace' is no longer in the parameter set '__AllParameterSets'.","Add parameter 'Tag' back to the parameter set '__AllParameterSets'."
+"D:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.AnalysisServices\Microsoft.Azure.Commands.AnalysisServices.dll","Microsoft.Azure.Commands.AnalysisServices.NewAnalysisServicesServer","New-AzureRmAnalysisServicesServer","0","2060","The position of parameter 'Administrator' has changed for parameter set '__AllParameterSets' for cmdlet 'New-AzureRmAnalysisServicesServer'.","Revert the position change made to parameter 'Administrator' for parameter set '__AllParameterSets'."


not removed

v-Ajnava · 2017-08-06T23:55:24Z

@markcowl , Resolved the comments.

cormacpayne · 2017-08-07T16:13:56Z

On-demand: http://azuresdkci.cloudapp.net/job/powershell-demand/1821/

markcowl · 2017-08-07T17:39:11Z

tools/StaticAnalysis/Exceptions/BreakingChangeIssues.csv

+"D:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.EventHub\Microsoft.Azure.Commands.EventHub.dll","Microsoft.Azure.Commands.EventHub.Commands.EventHub.GetAzureRmEventHubAuthorizationRule","Get-AzureRmEventHubAuthorizationRule","0","2100","The parameter 'EventHubName' in cmdlet 'Get-AzureRmEventHubAuthorizationRule' is no longer in the parameter set '__AllParameterSets'.","Add parameter 'EventHubName' back to the parameter set '__AllParameterSets'."
+"D:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.EventHub\Microsoft.Azure.Commands.EventHub.dll","Microsoft.Azure.Commands.EventHub.Commands.EventHub.GetAzureEventHubKey","Get-AzureRmEventHubKey","0","2100","The parameter 'NamespaceName' in cmdlet 'Get-AzureRmEventHubKey' is no longer in the parameter set '__AllParameterSets'.","Add parameter 'NamespaceName' back to the parameter set '__AllParameterSets'."
+"D:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.EventHub\Microsoft.Azure.Commands.EventHub.dll","Microsoft.Azure.Commands.EventHub.Commands.EventHub.GetAzureEventHubKey","Get-AzureRmEventHubKey","0","2100","The parameter 'EventHubName' in cmdlet 'Get-AzureRmEventHubKey' is no longer in the parameter set '__AllParameterSets'.","Add parameter 'EventHubName' back to the parameter set '__AllParameterSets'."
+"D:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.EventHub\Microsoft.Azure.Commands.EventHub.dll","Microsoft.Azure.Commands.EventHub.Commands.EventHub.NewAzureRmEventHub","New-AzureRmEventHub","0","2060","The position of parameter 'EventHubName' has changed for parameter set '__AllParameterSets' for cmdlet 'New-AzureRmEventHub'.","Revert the position change made to parameter 'EventHubName' for parameter set '__AllParameterSets'."


New-AzureRmEventHub EventHubName position has changed. This is a breaking change. Please change it back

Actually, looks liek this is just stale. Please remove this in a separate PR.

Sure, will raise a separate PR.

msftclas added the cla-already-signed label Jul 13, 2017

azuresdkci added the needs-review label Jul 13, 2017

azuresdkci assigned markcowl Jul 13, 2017

markcowl added needs-revision and removed needs-review labels Jul 15, 2017

markcowl assigned v-Ajnava and unassigned markcowl Jul 15, 2017

markcowl self-requested a review July 15, 2017 00:09

v-Ajnava added needs-review and removed needs-revision labels Jul 17, 2017

markcowl requested changes Jul 21, 2017

View reviewed changes

markcowl added needs-revision and removed needs-review labels Jul 21, 2017

v-Ajnava force-pushed the EHpwr2017 branch from e28420a to 14c4c6f Compare July 24, 2017 04:16

v-Ajnava added needs-review and removed needs-revision labels Jul 25, 2017

cormacpayne suggested changes Jul 26, 2017

View reviewed changes

cormacpayne added needs-revision and removed needs-review labels Jul 26, 2017

cormacpayne mentioned this pull request Jul 26, 2017

Servicebus : RP version 2017-04-01 and cmdlet recommendations #4363

Merged

13 tasks

v-Ajnava added needs-review and removed needs-revision labels Jul 27, 2017

markcowl added needs-revision Merge Conflicts and removed needs-review labels Jul 31, 2017

EventHub RP version 2017-04-01 changes

28baa4a

updated the parameterset

25ce462

markcowl added Waiting for On Demand and removed needs-review labels Aug 3, 2017

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

f1c8c93

…nto EHpwr2017

cormacpayne changed the base branch from preview to release-4.3.0 August 4, 2017 15:59

cormacpayne previously approved these changes Aug 4, 2017

View reviewed changes

cormacpayne unassigned v-Ajnava Aug 4, 2017

cormacpayne reviewed Aug 4, 2017

View reviewed changes

Corrected the markdown

a2d81f5

v-Ajnava dismissed cormacpayne’s stale review via a2d81f5 August 4, 2017 18:08

REDMOND\v-ajnava and others added 3 commits August 4, 2017 12:53

fixed signatureissues

f5c0fcb

Update SignatureIssues.csv

b700071

Merge branch 'release-4.3.0' into EHpwr2017

0c0b56e

markcowl requested changes Aug 5, 2017

View reviewed changes

markcowl added needs-revision and removed Waiting for On Demand labels Aug 5, 2017

Corrected BreakingChangeIssues.csv

ea9b657

v-Ajnava added needs-review and removed needs-revision labels Aug 6, 2017

cormacpayne added Waiting for On Demand and removed needs-review labels Aug 7, 2017

markcowl approved these changes Aug 7, 2017

View reviewed changes

cormacpayne approved these changes Aug 7, 2017

View reviewed changes

cormacpayne merged commit c09c61c into Azure:release-4.3.0 Aug 7, 2017

v-Ajnava deleted the EHpwr2017 branch April 12, 2018 01:37

		@@ -1,9 +1,14 @@
		<?xml version="1.0" encoding="utf-8"?>
		<?xml version="1.0" encoding="utf-8"?>

EventHub: RP version 2017-04-01 and cmdlet recommendations #4307

EventHub: RP version 2017-04-01 and cmdlet recommendations #4307

Uh oh!

Conversation

v-Ajnava commented Jul 13, 2017 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

renamed cmdlet parameters with recommended and added old names as alias.

Uh oh!

markcowl commented Jul 15, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

v-Ajnava commented Jul 25, 2017

Uh oh!

cormacpayne commented Jul 25, 2017

Uh oh!

cormacpayne left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

v-Ajnava commented Jul 13, 2017 •

edited by azuresdkci

Loading