Relay: RP version 2017-04-01 #4380

v-Ajnava · 2017-07-28T02:07:49Z

Description

PR consist the changes related RP version 2017-04-01

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

I have read the contribution guidelines.
If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

Pull request includes test coverage for the included changes.
PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

…nto Relaypwr2017

markcowl · 2017-07-31T03:59:05Z

src/ResourceManager/Relay/Commands.Relay/Models/AuthorizationRuleAttributes.cs

+            {
+                Rights.Add(teset.ToString());
+            }
+            //Rights = authorizationrule.Rights.Select(x => Enum.Parse(typeof(AccessRights?), x))


remove commented code

markcowl · 2017-07-31T03:59:37Z

src/ResourceManager/Relay/Commands.Relay/Models/AuthorizationRuleAttributes.cs

+
+            Rights = new List<string>();
+
+            foreach (AccessRights teset in authorizationrule.Rights)


teset == typo?

corrected to a meaningful name

markcowl · 2017-07-31T04:00:23Z

src/ResourceManager/Relay/Commands.Relay/Models/AuthorizationRuleKeysAttributes.cs

@@ -46,7 +46,7 @@ public AuthorizationRuleKeysAttributes(string primaryConnectionString = default(
        /// Initializes a new instance of the AuthorizationRuleKeysAttributes class with a Azure.Management.Relay.Models.AuthorizationRuleKeys
        /// </summary>
        /// <param name="authorizationruleskeys"></param>
-        public AuthorizationRuleKeysAttributes(AuthorizationRuleKeys authorizationruleskeys)
+        public AuthorizationRuleKeysAttributes(AccessKeys authorizationruleskeys)


Did the type of an output type or parameter type change? Were there any properties removed?

just the name has been changed in the SDK, properties are same and cmdlet dosent expose it.

markcowl · 2017-07-31T04:01:53Z

src/ResourceManager/Relay/Commands.Relay/Models/RelayNamespaceAttributesUpdateParameter.cs

@@ -40,7 +40,7 @@ public RelayNamespaceAttirbutesUpdateParameter(IDictionary<string, string> tags
            Tags = tags;
        }

-        public RelayNamespaceAttirbutesUpdateParameter(RelayNamespaceUpdateParameter relaynamespaceupdateparameter)
+        public RelayNamespaceAttirbutesUpdateParameter(RelayUpdateParameters relaynamespaceupdateparameter)


does this new type have all the properties of the old type? If not, is this exposed via cmdlet output or parameters?

the new type has all the same properties just the name has been changed and its not exposed via cmdlet output or parameters.

…nto Relaypwr2017 # Conflicts: # src/ResourceManager/Relay/Commands.Relay/Commands.Relay.csproj # src/ResourceManager/Relay/Commands.Relay/packages.config

markcowl · 2017-08-01T20:08:28Z

on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1786/

markcowl · 2017-08-01T22:23:56Z

@azuresdkci retest this please

cormacpayne

@v-Ajnava @markcowl waiting for Ajit to make one last change mentioned offline

cormacpayne

@v-Ajnava a couple comments as a result of the merge after the Common.Dependencies project went through

cormacpayne · 2017-08-02T23:57:06Z

src/ResourceManager/Relay/Commands.Relay/Commands.Relay.csproj

@@ -41,10 +41,71 @@
    <Prefer32Bit>false</Prefer32Bit>
  </PropertyGroup>
  <ItemGroup>
-    <Reference Include="Microsoft.Azure.Management.Relay, Version=0.0.1.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">


@v-Ajnava please revert the changes made in this file. I assume they are a result of a merge conflict after our Common.Dependencies PR went through. The only thing that should be in csproj files should be the management libraries that the project depends on. In this case, it should just be the Relay management library. Everything else is defined in Common.Dependencies.targets

Removed the other than required dependencies

cormacpayne · 2017-08-02T23:58:36Z

src/ResourceManager/Relay/Commands.Relay/packages.config

  <package id="Microsoft.Azure.Management.Resources" version="2.20.0-preview" targetFramework="net45" />
  <package id="Microsoft.Azure.Management.Storage" version="3.0.0" targetFramework="net45" />
  <package id="Microsoft.Azure.Management.Websites" version="1.2.0-preview" targetFramework="net45" />
+  <package id="Microsoft.Bcl" version="1.1.9" targetFramework="net45" />


@v-Ajnava similar comment to the one made in the csproj file. The packages.config file should only have a reference on the management packages you need.

Removed the other than required dependencies

markcowl · 2017-08-03T03:19:41Z

src/ResourceManager/Relay/Commands.Relay/Commands.Relay.csproj

+    <Reference Include="Microsoft.Azure.Common.NetFramework">
+      <HintPath>..\..\..\packages\Microsoft.Azure.Common.2.1.0\lib\net45\Microsoft.Azure.Common.NetFramework.dll</HintPath>
+    </Reference>
+    <Reference Include="Microsoft.Azure.Management.Relay, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">


You only need the relay reference in this file. The rest come from the comnmon dependences target

Removed other dependencies

@v-Ajnava extra dependencies are still showing up in this file

Removed the Extra dependencies

…nto Relaypwr2017

cormacpayne · 2017-08-04T18:42:09Z

On-demand: http://azuresdkci.cloudapp.net/job/powershell-demand/1810/

Approved

Relay RP version 2017-04-01 changes

4bb66e3

msftclas added the cla-already-signed label Jul 28, 2017

azuresdkci added the needs-review label Jul 28, 2017

azuresdkci assigned cormacpayne Jul 28, 2017

REDMOND\v-ajnava added 4 commits July 28, 2017 09:57

removed app.config

e8537bb

Newtonsoft package version corrected.

d6a30a8

Session record.

d70b8eb

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

55337f8

…nto Relaypwr2017

markcowl requested changes Jul 31, 2017

View reviewed changes

markcowl added needs-revision and removed needs-review labels Jul 31, 2017

REDMOND\v-ajnava added 2 commits July 31, 2017 12:38

review comments.

c8d053c

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

00e9354

…nto Relaypwr2017 # Conflicts: # src/ResourceManager/Relay/Commands.Relay/Commands.Relay.csproj # src/ResourceManager/Relay/Commands.Relay/packages.config

v-Ajnava added needs-review and removed needs-revision labels Jul 31, 2017

markcowl previously approved these changes Aug 1, 2017

View reviewed changes

markcowl added Waiting for On Demand and removed needs-review labels Aug 1, 2017

cormacpayne suggested changes Aug 1, 2017

View reviewed changes

Added ResourceGroup to Namespace Attribute

7a20a7c

v-Ajnava dismissed markcowl’s stale review via 7a20a7c August 1, 2017 22:54

v-Ajnava added the needs-review label Aug 1, 2017

cormacpayne removed the Waiting for On Demand label Aug 2, 2017

cormacpayne suggested changes Aug 2, 2017

View reviewed changes

cormacpayne added needs-revision and removed needs-review labels Aug 2, 2017

cormacpayne assigned v-Ajnava and unassigned cormacpayne Aug 2, 2017

updated the Dependencies

bbaa57a

v-Ajnava added needs-review and removed needs-revision labels Aug 3, 2017

markcowl previously requested changes Aug 3, 2017

View reviewed changes

REDMOND\v-ajnava added 2 commits August 2, 2017 20:39

Removed the dependencies from croj and package.config files

2bab6f0

Removed extra dependencies

d574793

markcowl added needs-revision and removed needs-review labels Aug 3, 2017

Azure deleted a comment from v-Ajnava Aug 3, 2017

v-Ajnava added needs-review and removed needs-revision labels Aug 3, 2017

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

de8cceb

…nto Relaypwr2017

cormacpayne changed the base branch from preview to release-4.3.0 August 4, 2017 16:03

cormacpayne approved these changes Aug 4, 2017

View reviewed changes

cormacpayne unassigned v-Ajnava Aug 4, 2017

cormacpayne added Waiting for On Demand and removed needs-review labels Aug 4, 2017

cormacpayne merged commit f9acea2 into Azure:release-4.3.0 Aug 4, 2017

v-Ajnava deleted the Relaypwr2017 branch April 12, 2018 01:17


		Rights = new List<string>();

		foreach (AccessRights teset in authorizationrule.Rights)

Relay: RP version 2017-04-01 #4380

Relay: RP version 2017-04-01 #4380

Uh oh!

Conversation

v-Ajnava commented Jul 28, 2017 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markcowl commented Aug 1, 2017

Uh oh!

markcowl commented Aug 1, 2017

Uh oh!

cormacpayne left a comment

Choose a reason for hiding this comment

Uh oh!

cormacpayne left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cormacpayne commented Aug 4, 2017

Uh oh!

Uh oh!

v-Ajnava commented Jul 28, 2017 •

edited by azuresdkci

Loading