Update signature script for strong name and authenticode #4462

cormacpayne · 2017-08-11T19:00:11Z

Description

Remove all CheckStrongNameSignature.ps1 script and replace it with CheckSignature.ps1 script that will check for strong name signature for dll files and authenticode signature for dll, ps1 and psm1 files.

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

I have read the contribution guidelines.
If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

Pull request includes test coverage for the included changes.
PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

cormacpayne · 2017-08-11T19:01:55Z

Sign job: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-sign/1246/
On-demand: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1841/

markcowl · 2017-08-14T00:37:44Z

tools/CheckSignature.ps1

+function Check-StrongName {
+    [CmdletBinding()]
+    param([Parameter(ValueFromPipeline=$true)][string]$path)
+    $output = & "sn.exe" -vf $path


We should check for the existence of sn.exe on the path and fail fast if it is not found at the beginning of the Check-All script.

markcowl · 2017-08-14T00:39:18Z

tools/CheckSignature.ps1

+}
+elseif ($PSCmdlet.ParameterSetName -eq "GalleryInstall")
+{
+    $path = "$($env:ProgramFiles)\WindowsPowerShell\Modules"


We should probably use $PSModulePath entries to determine where to search

markcowl · 2017-08-14T00:40:03Z

tools/CheckSignature.ps1

+
+if ($PSCmdlet.ParameterSetName -eq "MsiInstall")
+{
+    $path = "${env:ProgramFiles(x86)}\Microsoft SDKs\Azure\PowerShell"


This will be different on a 32-bit system (this variable is not defined, in that case). We should check for existence of the variable, or bitness of the OS before proceeding

markcowl · 2017-08-14T00:41:31Z

@cormacpayne Used this to check the current release candidate in both installation types and it was really slick, excellent work! A few suggestions to make this work over all environments.

…switch to find and check modules

cormacpayne · 2017-08-23T16:08:31Z

Sign-job: http://azuresdkci.cloudapp.net/job/powershell-sign/1287/

markcowl · 2017-08-25T16:43:12Z

tools/CheckSignature.ps1

+
+    $invalidList = @()
+
+    $files = Get-ChildItem $path\* -Include *.dll -Recurse | Where-Object { $_.FullName -like "*Azure*" }


For the future, it would be useful to factor out this file test iterator into its own function, so that you're calling it twice here, rather than duplicating the code.

cormacpayne · 2017-08-25T16:54:34Z

Sign job: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-sign/1293/

markcowl

Failures are not being bubbled up, otherwise, lgtm

markcowl · 2017-08-25T16:53:23Z

build.proj

@@ -381,7 +381,7 @@
      <Output TaskParameter="AuthCodeSignTaskErrorsDetected" PropertyName="AuthTaskFailed" />
    </VerifyAuthenticodeSignatureTask>

-    <Exec Command="&quot;$(PowerShellCommand)&quot; -NonInteractive -NoLogo -NoProfile -Command &quot;. $(LibraryToolsFolder)\CheckStrongNameSignature.ps1 &quot;"/>
+    <Exec Command="&quot;$(PowerShellCommand)&quot; -NonInteractive -NoLogo -NoProfile -Command &quot;. $(LibraryToolsFolder)\CheckSignature.ps1 -CustomPath $(LibrarySourceFolder)\Package\$(Configuration) &quot;"/>


We need to ensure that execution continues but marks this as an error, right now it looks like errors are not being bubbled up to fail the ci job. We may need to change the setting of this task and look at the erroractionpreference in powershell (or explicitly throw an exception.

cormacpayne · 2017-08-28T18:07:10Z

Sign job: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-sign/1297/
On-demand: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1857/

Update signature script for strong name and authenticode

c08a421

cormacpayne assigned markcowl Aug 11, 2017

msftclas added the cla-not-required label Aug 11, 2017

azuresdkci added the needs-review label Aug 11, 2017

markcowl requested changes Aug 14, 2017

View reviewed changes

markcowl added needs-revision and removed needs-review labels Aug 14, 2017

markcowl assigned cormacpayne and unassigned markcowl Aug 14, 2017

cormacpayne changed the base branch from release-4.3.1 to preview August 18, 2017 17:39

Resolve review comments, add more error checks, add -AzurePowerShell …

4bbc7a2

…switch to find and check modules

cormacpayne added needs-review and removed needs-revision labels Aug 23, 2017

cormacpayne assigned markcowl and unassigned cormacpayne Aug 23, 2017

markcowl previously approved these changes Aug 25, 2017

View reviewed changes

Fail sign job if CheckSignature.ps1 fails

9f3ceb6

cormacpayne dismissed markcowl’s stale review via 9f3ceb6 August 25, 2017 16:52

markcowl requested changes Aug 25, 2017

View reviewed changes

markcowl assigned cormacpayne and unassigned markcowl Aug 25, 2017

markcowl added needs-revision and removed needs-review labels Aug 25, 2017

markcowl approved these changes Sep 1, 2017

View reviewed changes

cormacpayne merged commit 9965641 into Azure:preview Sep 6, 2017

cormacpayne deleted the signature-script branch November 9, 2017 21:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update signature script for strong name and authenticode #4462

Update signature script for strong name and authenticode #4462

Uh oh!

cormacpayne commented Aug 11, 2017

Uh oh!

cormacpayne commented Aug 11, 2017

Uh oh!

markcowl Aug 14, 2017

Uh oh!

markcowl Aug 14, 2017

Uh oh!

markcowl Aug 14, 2017

Uh oh!

markcowl commented Aug 14, 2017 •

edited

Loading

Uh oh!

cormacpayne commented Aug 23, 2017

Uh oh!

markcowl Aug 25, 2017

Uh oh!

cormacpayne commented Aug 25, 2017

Uh oh!

markcowl left a comment

Uh oh!

markcowl Aug 25, 2017

Uh oh!

cormacpayne commented Aug 28, 2017

Uh oh!

Uh oh!


		$invalidList = @()

		$files = Get-ChildItem $path\* -Include .dll -Recurse \| Where-Object { $_.FullName -like "Azure*" }

Update signature script for strong name and authenticode #4462

Update signature script for strong name and authenticode #4462

Uh oh!

Conversation

cormacpayne commented Aug 11, 2017

Description

Uh oh!

cormacpayne commented Aug 11, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markcowl commented Aug 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cormacpayne commented Aug 23, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cormacpayne commented Aug 25, 2017

Uh oh!

markcowl left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cormacpayne commented Aug 28, 2017

Uh oh!

Uh oh!

markcowl commented Aug 14, 2017 •

edited

Loading