Skip to content

Remove StorageContainer Parameter from Import/Export Commands #4619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2017

Conversation

trgrie
Copy link
Contributor

@trgrie trgrie commented Sep 19, 2017

Description

The issue this pull request fixes was originally filed here.

This change removes the StorageContainer parameters from the Import and Export commands, which also involves removing requiring the StorageContainer parameter in any form of the command. The necessary test changes were also made (and ran) as part of this change.

Removing the StorageContainer parameter does not cause any issues since the commands did not work with it anyways, this just makes it clearer for the user to use StorageContainerName with a StorageContext instead.


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

Remove StorageContainer Parameter from Import/Export Commands
Remove StorageContainer Parameter from Import/Export Commands
@azuresdkci
Copy link

Can one of the admins verify this patch?

@markcowl
Copy link
Member

@trgrie we build the maml help file from markdown files, so this would not be the appropriate place to make this change.

@Azure Azure deleted a comment from msftclas Sep 26, 2017
@Azure Azure deleted a comment from msftclas Sep 26, 2017
@markcowl
Copy link
Member

@trgrie never mind, since this is SM, the MAML help file is where to make this change.

@markcowl
Copy link
Member

@jaredmoo @akromm could one of you guys review this PR?

@markcowl markcowl assigned jaredmoo and akromm-zz and unassigned shahabhijeet Sep 28, 2017
@cormacpayne
Copy link
Member

@trgrie you will need to sign the CLA before this can be merged. You can sign the CLA by clicking the Details button in the status check panel at the bottom of this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants