Skip to content

Release 4.4.0 -> Master #4648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 533 commits into from
Sep 25, 2017
Merged

Release 4.4.0 -> Master #4648

merged 533 commits into from
Sep 25, 2017

Conversation

markcowl
Copy link
Member

Description


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

murilogr and others added 30 commits September 15, 2017 11:17
…into preview

# Conflicts:
#	src/ResourceManager/Compute/Commands.Compute.Test/SessionRecords/Microsoft.Azure.Commands.Compute.Test.ScenarioTests.VirtualMachineScaleSetTests/TestVirtualMachineScaleSetLB.json
#	src/ResourceManager/Compute/Commands.Compute.Test/packages.config
#	src/ResourceManager/Compute/Commands.Compute/packages.config
Cmdlets: port grouping and Effective NSGs, ILB HA and DDoSProtection
Adding basic SQL virtual network rules functionality
from read-write instance to read-only instances
    - Included help file for the commandlet
        - Added in-memory tests and a scenario test (only live)
	* Fixed bugs in Add-AzureAsAccount commandlet
commit 5642230
Author: athipp <[email protected]>
Date:   Sun Sep 17 11:21:39 2017 -0700

    * Added a new dataplane commandlet to allow synchronization of databases
    from read-write instance to read-only instances
        - Included help file for the commandlet
            - Added in-memory tests and a scenario test (only live)
    	* Fixed bugs in Add-AzureAsAccount commandlet
cormacpayne and others added 26 commits September 22, 2017 09:48
Add managed application cmdlets
Add new commandlets for VpnDevice Configuration Scripts
…ts-1

Adding new cmdlets for NodeConfiguration Deployments
Activity Log Alert cmdlets
Adfv2ignite -with latest help updates
Azure Event Grid: First version of PowerShell support
update remove role assignment commandlet
Fix add-environment ARMEndpoint functionality
Nullify default NetworkSecurityRules if absent
@markcowl markcowl merged commit 9ae3103 into master Sep 25, 2017
@markcowl markcowl deleted the release-4.4.0 branch November 14, 2017 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.