-
Notifications
You must be signed in to change notification settings - Fork 4k
[Experiment][Compute] Tab completion for New-AzVm #4655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Experiment][Compute] Tab completion for New-AzVm #4655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what most of the changes are doing, but the Register-ArgumentCompleter code looks good to me.
@sergey-shandar did not get a chance to update the preview branch with this, will review on return. |
New-AzVm -Name MyVM -Credential $vmCredential -WhatIf | ||
} | ||
It 'Create Windows VM' { | ||
New-AzVm -Name MyVMA1 -Credential $vmCredential -ResourceGroupName Something1 -Verbose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should pair this with some validations, like validating the output of the cmdlet, and perhaps performing a Get and verifying proeprties for the expected resources.
|
||
# Modules that must be imported into the global environment prior to importing this module | ||
RequiredModules = @( | ||
@{ ModuleName = "AzureRM.Resources"; ModuleVersion = "4.3.2"; }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compute = 3.4.0, Network = 4.4.0, Resources = 4.4.0
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines