Skip to content

AzureRT - Fix Problem of Adding Extension while using New/Set-AzureDeployment #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jun 8, 2015
Merged

AzureRT - Fix Problem of Adding Extension while using New/Set-AzureDeployment #466

merged 19 commits into from
Jun 8, 2015

Conversation

huangpf
Copy link
Contributor

@huangpf huangpf commented Jun 5, 2015

No description provided.

@azurecla
Copy link

azurecla commented Jun 5, 2015

Hi @huangpf, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (phuang). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@huangpf
Copy link
Contributor Author

huangpf commented Jun 5, 2015

Follow-up for PR/Fix: #361

@huangpf
Copy link
Contributor Author

huangpf commented Jun 5, 2015

Follow-up for Issue: #193

hyonholee
hyonholee reviewed Jun 5, 2015
View reviewed changes
...mmands.ServiceManagement.Test/FunctionalTests/IaasCmdletInfo/SetAzureDeploymentCmdletInfo.cs
{
SetAzureDeploymentCmdletInfo result = new SetAzureDeploymentCmdletInfo(serviceName, slot);

result.cmdletParams.Add(new CmdletParam("Config"));
result.cmdletParams.Add(new CmdletParam("Configuration", configPath));
result.cmdletParams.Add(new CmdletParam("ExtensionConfiguration", extConfig));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are Set-AzureDeployment with "-ExtensionConfiguration $null" parameter and Set-AzureDeployment without -ExtensionConfiguration paramter the same?
If they are the same, this line should be added when 'extConfig' is not null.
If they are not the same, we need two separate methods, with $null extConfig and without extConfig.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@ogail
Copy link
Contributor

ogail commented Jun 6, 2015

@huangpf please fix merge conflicts

@huangpf
Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev
85ba01b 
Conflicts:
	src/ServiceManagement/Compute/Commands.ServiceManagement.Test/Commands.ServiceManagement.Test.csproj
@huangpf
Copy link
Contributor Author

huangpf commented Jun 6, 2015

@ogail OK. Updated & waiting for the build/test.

@huangpf
Copy link
Contributor Author

huangpf commented Jun 6, 2015

@hyonholee Can you help sign off if no other concerns? Thanks.

@hyonholee
Copy link
Contributor

LGTM

ogail added a commit that referenced this pull request Jun 8, 2015
@ogail
Merge pull request #466 from huangpf/dev
480d0da 
AzureRT - Fix Problem of Adding Extension while using New/Set-AzureDeployment
@ogail ogail merged commit 480d0da into Azure:dev Jun 8, 2015
huangpf added a commit to AzureRT/azure-powershell that referenced this pull request Mar 12, 2016
@huangpf
Merge pull request Azure#466 from Azure/dev
6978caa 
HPF PR: dev <- Azure:dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@huangpf @azurecla @ogail @hyonholee