-
Notifications
You must be signed in to change notification settings - Fork 4k
Replaced RouteTables and Routes with generated #4689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
namespace Microsoft.Azure.Commands.Network.Automation | ||
{ | ||
[Cmdlet("Get", "AzureRmRouteConfig", SupportsShouldProcess = true), OutputType(typeof(PSRoute))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EvgenyAgafonchikov GET cmdlets shouldn't support ShouldProcess
; I would update the generator to reflect this.
namespace Microsoft.Azure.Commands.Network.Automation | ||
{ | ||
|
||
[Cmdlet(VerbsCommon.Set, "AzureRmRouteTable"), OutputType(typeof(PSRouteTable))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EvgenyAgafonchikov this cmdlet should support ShouldProcess
a7b17f3
to
bd03640
Compare
@EvgenyAgafonchikov one last thing, the markdown files for the corresponding cmdlets you made the |
@EvgenyAgafonchikov ping |
75f9ff3
to
e9bf0a7
Compare
Description
[Draft version to discuss possible generation improvements etc.]
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines