-
Notifications
You must be signed in to change notification settings - Fork 4k
Add migration guide for Stack AzureRm 1.2.11 #4722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -0,0 +1,117 @@ | |||
# Table of Contents | |||
1. [Removal of Force parameters](#removal-of-force-parameters) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you will want to add in the changes from the migration guides for 2.X and 3.X powershell for the modules you are using (Profile esp.): https://github.com/Azure/azure-powershell/blob/preview/documentation/release-notes/migration-guide.2.0.0.md, https://github.com/Azure/azure-powershell/blob/preview/documentation/release-notes/migration-guide.3.0.0.md, https://github.com/Azure/azure-powershell/blob/preview/documentation/release-notes/migration-guide.4.0.0.md
# Table of Contents | ||
1. [Removal of Force parameters](#removal-of-force-parameters) | ||
2. [Change of Tag parameters](#change-of-tag-parameters) | ||
3. [Breaking Changes to Profile Cmdlets](#breaking-changes-to-profile-cmdlets) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also have changes in the Get-AzureRmSubscription and Select-AzureRmSubscription cmdlets differring in outputs from 1.2.10
We cannot pipe azurestack subscription model to Select-AzureRmSubscription, we need to call these out
@markcowl vishnu added the Profile Changes from 3.0 and 4.0 |
Thanks again! |
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines