-
Notifications
You must be signed in to change notification settings - Fork 4k
Fix comparison of Scope field in PAS - RoleAssignment Resource #4803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cormacpayne
merged 8 commits into
Azure:preview
from
AshishGargMicrosoft:ashigarg/PowerShellChanges
Oct 26, 2017
Merged
Fix comparison of Scope field in PAS - RoleAssignment Resource #4803
cormacpayne
merged 8 commits into
Azure:preview
from
AshishGargMicrosoft:ashigarg/PowerShellChanges
Oct 26, 2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto ashigarg/PowerShellChanges
…nto ashigarg/PowerShellChanges
Can one of the admins verify this patch? |
@darshanhs90 Hey Haridarshan, would you mind signing off on this PR if everything looks good? |
@cormacpayne - darshanhs90 is OOF till end of Oct. Is there anyone else who can approve this? |
@azuresdkci add to whitelist |
shaosong2017
previously approved these changes
Oct 23, 2017
cormacpayne
approved these changes
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines