Skip to content

Fix comparison of Scope field in PAS - RoleAssignment Resource #4803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AshishGargMicrosoft
Copy link
Contributor

@AshishGargMicrosoft AshishGargMicrosoft commented Oct 16, 2017

Description


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

@msftclas
Copy link

msftclas commented Oct 16, 2017

CLA assistant check
All CLA requirements met.

@azuresdkci
Copy link

Can one of the admins verify this patch?

@cormacpayne
Copy link
Member

@darshanhs90 Hey Haridarshan, would you mind signing off on this PR if everything looks good?

@AshishGargMicrosoft
Copy link
Contributor Author

@cormacpayne - darshanhs90 is OOF till end of Oct. Is there anyone else who can approve this?

@cormacpayne
Copy link
Member

@azuresdkci add to whitelist

@markcowl markcowl assigned cormacpayne and unassigned darshanhs90 Oct 23, 2017
@cormacpayne cormacpayne requested review from perseusCode and removed request for perseusCode October 23, 2017 18:09
@shaosong2017 shaosong2017 self-requested a review October 23, 2017 23:04
shaosong2017
shaosong2017 previously approved these changes Oct 23, 2017
@cormacpayne cormacpayne merged commit 6eab10f into Azure:preview Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants