Azure-Powershell pull #482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1822395 OneSDK : BugBash : Get-AzureSiteRecoverySite - help not in sync 1852200 OneSDK : BugBash : Update help of get-job to have updated time
Error reads as below when a directory is input: PS C:\> $Out = Get-AzureSiteRecoveryRecoveryPlanFile -Path C:\Windows -RecoveryPlan $RPList[0] Get-AzureSiteRecoveryRecoveryPlanFile : Operation failed. The input path is a directory. Please provide file path. Check the examples of commandlets Parameter name: Path At line:1 char:8 + $Out = Get-AzureSiteRecoveryRecoveryPlanFile -Path C:\Windows -RecoveryPlan $RPL ... + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + CategoryInfo : CloseError: (:) [Get-AzureSiteRecoveryRecoveryPlanFile], Exception + FullyQualifiedErrorId : Microsoft.Azure.Commands.RecoveryServices.GetAzureSiteRecoveryRecoveryPlanFile
Bugs 1822395 and 1852200
Adding format file for display of ProtectionProfileObject
enable tests
This reverts commit 9afabcd.
Test fix wrt Storage & Network mappings
ignoreCertificateHandler to make OneBox setup work (to be reverted befor...
updated Wait for CanFailOver state logic
This reverts commit 61a9a96.
Missed this with the previous commit for display of protection profile object.
Update protection profile
Removing validations - put them in service
Powershell changes for SAN (Cloud pairing/unpairing, enable and disable RG)
fixing NuGet dependency instead of DLL, UpdateVmPropertiesInput to VMProperties
Conflicts: setup/azurecmdfiles.wxi src/ServiceManagement/RecoveryServices/Commands.RecoveryServices.Test/Commands.RecoveryServices.Test.csproj src/ServiceManagement/RecoveryServices/Commands.RecoveryServices.Test/packages.config src/ServiceManagement/RecoveryServices/Commands.RecoveryServices/Commands.RecoveryServices.csproj src/ServiceManagement/RecoveryServices/Commands.RecoveryServices/packages.config
UpdateVMProperties, change in test, udpated JSONs
updated wxi file after running BuildInstaller.ps1
up work (to be reverted before final PR)" This reverts commit 56ea528.
Revert "ignoreCertificateHandler to make OneBox se
|
Can one of the admins verify this patch? |
|
Hi @vijaynar, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
|
@vijaynar There are merge conflicts, please update the PR |
Conflicts: setup/azurecmdfiles.wxi src/ServiceManagement/RecoveryServices/Commands.RecoveryServices.Test/ScenarioTests/RecoveryServicesTests.cs src/ServiceManagement/RecoveryServices/Commands.RecoveryServices.Test/packages.config src/ServiceManagement/RecoveryServices/Commands.RecoveryServices/packages.config src/ServiceManagement/Services/Commands.Utilities/Azure.psd1
Conflicts: src/ServiceManagement/RecoveryServices/Commands.RecoveryServices.Test/packages.config src/ServiceManagement/RecoveryServices/Commands.RecoveryServices/packages.config
|
@azuresdkci add to whitelist |
|
@vijaynar tests failed please investigate |
removed the duplicates
|
@azuresdkci retest this please |
|
@vijaynar Why is there a test dll included in this PR? Please remove the test dll. This makes it very difficult for contributors. If this is necessary, why can't it be built in this repo? |
|
@vijaynar Please add updates to changelog.txt for these changes |
have added changes wrt Recovery Services.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.