-
Notifications
You must be signed in to change notification settings - Fork 4k
Change Get-AzureRmWebAppPublishingProfile -OutputFile mandatory to option. #4827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… to option. OutputFile contains credentials. The current cmdlet returns XML, so you do not need to write it in a file. Mandatory is bad design. fix #4212
I had some mistake in test scenario. I will fix later. Please give me some time. |
…bAppSlotPublishingProfile.
@markcowl I corrected and confirmed that there is no problem locally. But your Jenkins seems to be broken. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the proposing the change, it is actually a good one.
approving the change.
@takekazuomi Can you regenerate the help files to reflect this change to the cmdlets? The documentation on how to do that is here |
@maddieclayton I regenerated help and confirmed the preview. LGTM |
Description
OutputFile contains credentials. The current cmdlet returns XML, so you do not need to write it in a file.
Mandatory is bad design.
fix #4212
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines