-
Notifications
You must be signed in to change notification settings - Fork 4k
Added zone redundant parameter to powershell commands. #4877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…and session records
@emgu-ms please fix the merge issues and push again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emgu-ms a few initial comments. Also, please make sure to update the Sql change log with a short snippet of the changes you made in this PR.
<package id="Microsoft.Azure.Management.Storage" version="2.4.0-preview" targetFramework="net45" /> | ||
<package id="Microsoft.Rest.ClientRuntime" version="2.3.10" targetFramework="net452" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emgu-ms please remove the three references added in this file. These packages are already loaded elsewhere.
…nto zoneRedundantChanges
…re-powershell into zoneRedundantChanges
…re-powershell into zoneRedundantChanges
Signed off times infinity :) |
@jaredmoo On-demand: https://azuresdkci.westus2.cloudapp.azure.com/job/powershell-demand/110/ LGTM once this passes |
Added zone redundant switch parameter to the following powershell commands:
This allows customers to specify whether they want their database/elastic pool in a zone redundant ring or not. I also updated the code flow such that Set-AzureRmSqlDatabase database model always uses the new AutoRest Sdk model.
Wrote new tests targeting zone redundancy parameter and updated session records for them.
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines