Skip to content

Added zone redundant parameter to powershell commands. #4877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 1, 2017

Conversation

emgu-ms
Copy link
Contributor

@emgu-ms emgu-ms commented Oct 27, 2017

Added zone redundant switch parameter to the following powershell commands:

  • New-AzureRmSqlDatabase
  • Set-AzureRmSqlDatabase
  • New-AzureRmSqlElasticPool
  • Set-AzureRmSqlElasticPool

This allows customers to specify whether they want their database/elastic pool in a zone redundant ring or not. I also updated the code flow such that Set-AzureRmSqlDatabase database model always uses the new AutoRest Sdk model.

Wrote new tests targeting zone redundancy parameter and updated session records for them.

Description


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

@maddieclayton
Copy link
Contributor

@emgu-ms please fix the merge issues and push again.

Copy link
Member

@cormacpayne cormacpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emgu-ms a few initial comments. Also, please make sure to update the Sql change log with a short snippet of the changes you made in this PR.

<package id="Microsoft.Azure.Management.Storage" version="2.4.0-preview" targetFramework="net45" />
<package id="Microsoft.Rest.ClientRuntime" version="2.3.10" targetFramework="net452" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emgu-ms please remove the three references added in this file. These packages are already loaded elsewhere.

@cormacpayne
Copy link
Member

@akromm @jaredmoo would one of you mind taking a look at this PR?

jaredmoo
jaredmoo previously approved these changes Oct 30, 2017
jaredmoo
jaredmoo previously approved these changes Oct 31, 2017
jaredmoo
jaredmoo previously approved these changes Nov 1, 2017
jaredmoo
jaredmoo previously approved these changes Nov 1, 2017
@jaredmoo
Copy link
Contributor

jaredmoo commented Nov 1, 2017

Signed off times infinity :)

@cormacpayne
Copy link
Member

@jaredmoo ☺️

On-demand: https://azuresdkci.westus2.cloudapp.azure.com/job/powershell-demand/110/

LGTM once this passes

@cormacpayne cormacpayne merged commit 1f1c88a into Azure:preview Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants