-
Notifications
You must be signed in to change notification settings - Fork 4k
Change encoding of .psd1, .psm1, .ps1xml files to UTF-8 #4916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this file: https://github.com/Azure/azure-powershell/pull/4916/files#diff-256420a0c31e2cdd314c1ed452196d55 should be removed.
@@ -13,7 +13,7 @@ Author = 'Microsoft Corporation' | |||
CompanyName = 'Microsoft Corporation' | |||
|
|||
# Copyright statement for this module | |||
Copyright = '© Microsoft Corporation. All rights reserved.' | |||
Copyright = '© Microsoft Corporation. All rights reserved.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright symbols chould be (c)
on demand run here: https://azuresdkci.westus2.cloudapp.azure.com/job/powershell-demand/128/ |
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines