Skip to content

Fixed the import issue when importing a DSC Node Configuration #4932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2017
Merged

Fixed the import issue when importing a DSC Node Configuration #4932

merged 2 commits into from
Dec 4, 2017

Conversation

vrdmr
Copy link
Member

@vrdmr vrdmr commented Nov 6, 2017

Description

This change fixes the issue with Import-AzureRmAutomationDscNodeConfiguration. There is an exception thrown when there is no NodeConfiguration available. This exception should be caught to do the subsequent processing (creating the new node configuration).


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

AutomationAccountName,
nodeConfigurationName,
null);
try
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a covering test

@markcowl markcowl assigned vrdmr and unassigned markcowl Nov 7, 2017
@cormacpayne
Copy link
Member

Closing this PR since there's been no action for two weeks. @vrdmr please feel free to re-open this when you get a chance to add test coverage for the change.

@cormacpayne
Copy link
Member

cormacpayne commented Nov 30, 2017

Test debt issue: #5048

@vrdmr informed me that they plan on re-recording all tests and resolving test debt issues next month when they have finished migrating to Swagger

@cormacpayne
Copy link
Member

@markcowl
Copy link
Member

markcowl commented Dec 1, 2017

@vrdmr Once you have signed off that you have verified this fix manually, we can merge. Please let us know once this is done.

@markcowl markcowl assigned vrdmr and unassigned markcowl Dec 1, 2017
@shawns1
Copy link

shawns1 commented Dec 1, 2017

@azuresdkci test this please

@markcowl markcowl assigned markcowl and unassigned markcowl Dec 4, 2017
@markcowl markcowl merged commit 9c9771b into Azure:preview Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants