-
Notifications
You must be signed in to change notification settings - Fork 4k
Fixed the import issue when importing a DSC Node Configuration #4932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the import issue when importing a DSC Node Configuration #4932
Conversation
AutomationAccountName, | ||
nodeConfigurationName, | ||
null); | ||
try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a covering test
Closing this PR since there's been no action for two weeks. @vrdmr please feel free to re-open this when you get a chance to add test coverage for the change. |
@vrdmr Once you have signed off that you have verified this fix manually, we can merge. Please let us know once this is done. |
@azuresdkci test this please |
Description
This change fixes the issue with Import-AzureRmAutomationDscNodeConfiguration. There is an exception thrown when there is no NodeConfiguration available. This exception should be caught to do the subsequent processing (creating the new node configuration).
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines