Skip to content

Removing RemoteApp cmdlets #4998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 1, 2017
Merged

Removing RemoteApp cmdlets #4998

merged 6 commits into from
Dec 1, 2017

Conversation

xamarsinx
Copy link
Contributor

@xamarsinx xamarsinx commented Nov 15, 2017

Description


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the wxi file to remove these dlls, and update the Azure module to not load these cmdlets and update its major version and release notes

@xamarsinx
Copy link
Contributor Author

have updated WXI, Azure module and version. The build was successful as well.

@xamarsinx
Copy link
Contributor Author

@markcowl can you please have a look.

Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one documentation issue, otherwise LGTM

ChangeLog.md Outdated
@@ -1,4 +1,49 @@
## 2017.11.10 Version 5.0.1
## 2017.11.20 Version 5.1.0
* Removed AzureRemoteApp Cmdles. Following is the list of removed Cmdlets
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not make this change here - this faile is updated by release tools. Instead, make the change to the Azure module changelog, here: https://github.com/Azure/azure-powershell/blob/preview/src/ServiceManagement/Services/Commands.Utilities/ChangeLog.md

@cormacpayne
Copy link
Member

@azuresdkci test this please

@@ -12,7 +12,7 @@
# RootModule = ''

# Version number of this module.
ModuleVersion = '5.0.0'
ModuleVersion = '5.1.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markcowl should this PR bump the version of Azure or should we bump it externally with our tooling?

Copy link
Member

@markcowl markcowl Dec 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should bump it. However, in this case, this should be OK

@markcowl markcowl removed their assignment Dec 1, 2017
@markcowl
Copy link
Member

markcowl commented Dec 1, 2017

@cormacpayne cormacpayne merged commit e9e63af into Azure:preview Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants