-
Notifications
You must be signed in to change notification settings - Fork 4k
Removing RemoteApp cmdlets #4998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the wxi file to remove these dlls, and update the Azure module to not load these cmdlets and update its major version and release notes
have updated WXI, Azure module and version. The build was successful as well. |
@markcowl can you please have a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one documentation issue, otherwise LGTM
ChangeLog.md
Outdated
@@ -1,4 +1,49 @@ | |||
## 2017.11.10 Version 5.0.1 | |||
## 2017.11.20 Version 5.1.0 | |||
* Removed AzureRemoteApp Cmdles. Following is the list of removed Cmdlets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not make this change here - this faile is updated by release tools. Instead, make the change to the Azure module changelog, here: https://github.com/Azure/azure-powershell/blob/preview/src/ServiceManagement/Services/Commands.Utilities/ChangeLog.md
@azuresdkci test this please |
@@ -12,7 +12,7 @@ | |||
# RootModule = '' | |||
|
|||
# Version number of this module. | |||
ModuleVersion = '5.0.0' | |||
ModuleVersion = '5.1.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markcowl should this PR bump the version of Azure
or should we bump it externally with our tooling?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should bump it. However, in this case, this should be OK
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines