Support create RM storage Account with Kind "Storagev2"

[blueww]

Description

Support create RM storage Account with Kind "Storagev2"
Also need to upgrade SRP SDK to 7.0. Since there's a breaking change in SRP SDK API for NetworkACL->NetworkRuleSet, PowerShell also has code change on it. But since Powershell has wrappered all interface for NetworkRuleSet, PowerShell don't have breaking on it.

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

• [Y ] I have read the contribution guidelines.
• [Y ] If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
• [Y ] If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

• [Y ] Title of the pull request is clear and informative.
• [Y ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
• [Y ] The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

• [Y ] Pull request includes test coverage for the included changes.
• [Y ] PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

• [ Y] New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
• [Y ] Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

• [Y ] Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
• [Y ] Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
• [Y ] Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

[blueww]

updated on-demand : https://azuresdkci.westus2.cloudapp.azure.com/job/powershell-demand/196/

[cormacpayne]

@azuresdkci test this please

[cormacpayne]

@blueww a couple of minor comments. Also, the NetworkAcls property of type StorageAccount was removed in the SDK, which is a breaking change. It looks like it was replaced by the NetworkRuleSet property, so this here's how it can be mitigated:

Create a new type PSStorageAccount, which is a wrapper over StorageAccount, and add the property NetworkAcls, which will just point to the NetworkRuleSet property. Add the Obsolete attribute on this property and add a message saying that this property will be removed in a future release. Let me know if you have any questions about this.

[cormacpayne]

@blueww you can remove the references added in this file (Microsoft.Rest.*, Newtonsoft.Json) since they are already referenced by the Common.Dependencies.targets file

[cormacpayne]

@blueww same comment about removing the added references since they are already referenced from a common project

[blueww]

@cormacpayne

For the breaking change, it's for New/Set-AzureStorageAccount cmdelts output has type "Microsoft.Azure.Management.Storage.Models.StorageAccount", and NetworkAcls is remove from the type.

But actually, the real return type of New/Set-AzureStorageAccount is "PSStorageAccount" (Yes, PSStorageAccount is already defined in PSH code, and used as output type of account cmdlets), you can see both cmdelts use "WriteStorageAccount(storageAccount)" to write output, and actually output Type is "PSStorageAccount":

        protected void WriteStorageAccount(StorageModels.StorageAccount storageAccount)
        {
            WriteObject(PSStorageAccount.Create(storageAccount, this.StorageClient));
        }

So I have correct the output type in New/Set-AzureStorageAccount to "PSStorageAccount". This will show a breaking change in StaticAnalysis for the output type change, but it's actually not breaking, since the output of the 2 cmdelts not change (only the output section in help *.md change). So I have added the 2 output type change into Exception of breaking change.

"d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.Storage\Microsoft.Azure.Commands.Management.Storage.dll","Microsoft.Azure.Commands.Management.Storage.NewAzureStorageAccountCommand","New-AzureRmStorageAccount","0","1020","The cmdlet 'New-AzureRmStorageAccount' no longer has output type 'Microsoft.Azure.Management.Storage.Models.StorageAccount'.","Make cmdlet 'New-AzureRmStorageAccount' return type 'Microsoft.Azure.Management.Storage.Models.StorageAccount'."

"d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.Storage\Microsoft.Azure.Commands.Management.Storage.dll","Microsoft.Azure.Commands.Management.Storage.SetAzureStorageAccountCommand","Set-AzureRmStorageAccount","0","1020","The cmdlet 'Set-AzureRmStorageAccount' no longer has output type 'Microsoft.Azure.Management.Storage.Models.StorageAccount'.","Make cmdlet 'Set-AzureRmStorageAccount' return type 'Microsoft.Azure.Management.Storage.Models.StorageAccount'."

I have fixed all other comments from you.
Let me know if you have any concern.
Thanks!

[cormacpayne]

@blueww the issue still remains: the NetworkAcls property is no longer accessible from the returned object of New/Set-AzureRmStorageAccount. You will need to add this property to the PSStorageAccount type so users are still able to use it in their scripts. Once you add this property, you can add the Obsolete attribute on it and let users know it will be removed in an upcoming breaking change release.

[cormacpayne]

@blueww one other thing, please make sure to update the ChangeLog.md file located in src/ResourceManager/Storage witha snippet about the changes you are making in this PR

[blueww]

@cormacpayne
The Change log is added ,and on-demand test updated on https://azuresdkci.westus2.cloudapp.azure.com/job/powershell-demand/196/.

For the NetworkACLs, I might don't clarify it clearly in before comments. Actually, no need to add NetworkACLs, since the original output don't have NetworkACLs.

The original output type of the 2 effected cmdelts New/Set-AzureRmStorageAccount are PSStorageAccount , you can see it in the code: all output storage Account will be converted to PSStorageAccount , then write to PowerShell output. So the original output don't have NetworkACLs.

The before breaking alarm is come from the output Type declared in the begin of cmdlet code is wrong:

• The declared Output Type is: OutputType(typeof(StorageModels.StorageAccount)) and StorageModels.StorageAccount has a property NetworkACLs missing .
• The actually output type is PSStorageAccount and it don't have breaking.

So I just correct the output type for the 2 cmdelts to OutputType(typeof(PSStorageAccount)), this make the real output type and the output type declared in code aligned. This fix is not a breaking, since it not change the output of the 2 cmdlets, but just correct the Output Section in help *.md file. Anyway, StaticAnaylsis report alarm since the declared output type change (real output type not change), so I added the 2 output type change into Exception of breaking change.

It's interesting that the OutputType of a cmdlet don't enforce to be aligned with the real output type of the cmdelts, actually there are some discussion on it like link

[cormacpayne]

@blueww thanks for the clarification ☺️ everything looks good