-
Notifications
You must be signed in to change notification settings - Fork 4k
RecoveryServices.Backup Bugfixes #5025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…Enabled Vault Credentials test case to be CheckIn Acceptance type.
1. Bug 1526979: Get-AzureRmRecoveryServicesBackupItem should do case insensitive comparison for container name filter 2. AzureVmItem should have property displaying ServiceClientModel.AzureIaaSVMProtectedItem.LastBackupTime 3. Some foundation for - Bug 1524000: [PowerShell][New-Ask] For V2 Vm restores, block storage accounts with Kind "Blob Storage" at PowerShell Removing traces of changes made for Storage.Kind
…in RecoveryServices projects. Updated the right path for ResourceManager dll
f12b9e0
to
fb59f63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dragonfly91 please update the change logs for RecoveryServices and RecoveryServices.Backup to reflect the changes being made in this PR
@@ -18,6 +18,8 @@ | |||
- Additional information about change #1 | |||
--> | |||
## Current Release | |||
* Fixed bug - Make vault credential cmdlet test compulsory for Check-In. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dragonfly91 if the only changes in this module were test changes, then you can go ahead and revert the changes made to this change log. There shouldn't be a need to ship another iteration of RecoveryServices
if there were no changes impacting customers.
Hi @cormacpayne I have undone my changes made to the RecoveryServices ChangeLog.md file. Can you please merge the PR? |
@twitchax looks like the travis build isn't running for this PR - is there an easy way to retrigger it? |
Closing and reopening to trigger the Travis job |
@maddieclayton, sorry, my bad for the delay. This PR needed a forward integrate from preview. I merged, and the CI should be kicked off now. |
No changes were made to common files that would break the netcore build, so I will just force merge this. |
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines