Skip to content

RecoveryServices.Backup Bugfixes #5025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 4, 2017
Merged

Conversation

dragonfly91
Copy link

@dragonfly91 dragonfly91 commented Nov 23, 2017

Description

  1. Fixed bug - Bug 1526979: Get-AzureRmRecoveryServicesBackupItem should do case insensitive comparison for container name filter
  2. Fixed bug - AzureVmItem should have property displaying ServiceClientModel.AzureIaaSVMProtectedItem.LastBackupTime
  3. Fixed bug - Make vault credential cmdlet test compulsory for Check-In
  4. Improvement - made tests self-sustaining.

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

Samuel Anudeep added 2 commits November 23, 2017 18:11
…Enabled Vault Credentials test case to be CheckIn Acceptance type.
1. Bug 1526979: Get-AzureRmRecoveryServicesBackupItem should do case insensitive comparison for container name filter
2. AzureVmItem should have property displaying ServiceClientModel.AzureIaaSVMProtectedItem.LastBackupTime
3. Some foundation for - Bug 1524000: [PowerShell][New-Ask] For V2 Vm restores, block storage accounts with Kind "Blob Storage" at PowerShell

Removing traces of changes made for Storage.Kind
…in RecoveryServices projects.

Updated the right path for ResourceManager dll
@cormacpayne
Copy link
Member

Copy link
Member

@cormacpayne cormacpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dragonfly91 please update the change logs for RecoveryServices and RecoveryServices.Backup to reflect the changes being made in this PR

@@ -18,6 +18,8 @@
- Additional information about change #1
-->
## Current Release
* Fixed bug - Make vault credential cmdlet test compulsory for Check-In.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dragonfly91 if the only changes in this module were test changes, then you can go ahead and revert the changes made to this change log. There shouldn't be a need to ship another iteration of RecoveryServices if there were no changes impacting customers.

@dragonfly91
Copy link
Author

dragonfly91 commented Nov 30, 2017

Hi @cormacpayne I have undone my changes made to the RecoveryServices ChangeLog.md file. Can you please merge the PR?

cormacpayne
cormacpayne previously approved these changes Nov 30, 2017
@cormacpayne
Copy link
Member

@maddieclayton
Copy link
Contributor

@twitchax looks like the travis build isn't running for this PR - is there an easy way to retrigger it?

@maddieclayton
Copy link
Contributor

Closing and reopening to trigger the Travis job

@twitchax
Copy link
Contributor

twitchax commented Dec 4, 2017

@maddieclayton, sorry, my bad for the delay. This PR needed a forward integrate from preview. I merged, and the CI should be kicked off now.

@maddieclayton
Copy link
Contributor

No changes were made to common files that would break the netcore build, so I will just force merge this.

@maddieclayton maddieclayton merged commit 87e230f into Azure:preview Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants