-
Notifications
You must be signed in to change notification settings - Fork 4k
[ADF] Adding Update-AzureRmDataFactoryV2 and Stop-AzureRmDataFactoryV2PipelineRun #5045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c9067fb
Adding Update-Datafactory cmdlet; Adding alias for Set- cmdlets to al…
hvermis 8f38bdf
Merge branch 'preview' of https://github.com/Azure/azure-powershell i…
hvermis 57f27f1
Initial check-in for cancel run feature
milantomic6 ceb7f8e
Updating Cencel Run cmdlet according to the review
hvermis 73157ad
Adding a test for Update-Factory n bringng -Frc back as StaticAnalysi…
hvermis 5b6a148
Addressed review comments
hvermis 0acbc7d
Modified test-run to also include stop-pipelinerun for the successful…
hvermis a87ab3a
Fixed Changelog.md
hvermis 93e3e70
Merge branch 'preview' into ADFv2
twitchax 3ffca26
Removed -Force from Update-DataFactory
hvermis 85f3b4e
Merge branch 'ADFv2' of https://github.com/hvermis/azure-powershell i…
hvermis ae4cc8c
Addressed review comments
hvermis 739b828
Removed Identity parameter from Update-Factory as backend doesn't sup…
hvermis 1433565
Updated from preview branch
hvermis 80492e9
Fixed reference for online help
hvermis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,5 +31,11 @@ public void TestRunV2() | |
RunPowerShellTest("Test-Run"); | ||
} | ||
|
||
[Fact] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add a test for a successful cancellation? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Modified the run test to include it |
||
[Trait(Category.AcceptanceType, Category.CheckIn)] | ||
public void TestCancelRunNegativeV2() | ||
{ | ||
RunPowerShellTest("Test-CancelRunNegative"); | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the change log with information about these two new cmdlets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done