Skip to content

Update Encryption Client for Data Factory PSH #5049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 1, 2017

Conversation

tongwu-sh
Copy link

@tongwu-sh tongwu-sh commented Nov 30, 2017

Description


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

@cormacpayne
Copy link
Member

@hvermis @bgold09 would you mind taking a look?

@cormacpayne cormacpayne assigned bgold09 and hvermis and unassigned cormacpayne Nov 30, 2017
@hvermis
Copy link
Contributor

hvermis commented Nov 30, 2017

@cormacpayne I have already reviews this internally and changes look good. The library version udate does not cause any POSH functionality or test change.

hvermis
hvermis previously approved these changes Nov 30, 2017
@bgold09 bgold09 removed their assignment Nov 30, 2017
@hvermis hvermis assigned cormacpayne and unassigned hvermis Nov 30, 2017
@cormacpayne
Copy link
Member

@cormacpayne cormacpayne removed their assignment Dec 1, 2017
@maddieclayton maddieclayton merged commit f197614 into Azure:preview Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants