Netcore fixes. #5063

twitchax · 2017-12-01T09:52:56Z

This change will cause the build to fail when a cmdlet name cannot be mapped to a documentation group.

In addition, there are some fixes to the Netcore build.

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

I have read the contribution guidelines.
If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

Pull request includes test coverage for the included changes.
PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

maddieclayton · 2017-12-01T16:56:58Z

On demand run here: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/powershell-demand/224/

twitchax · 2017-12-03T23:13:10Z

@cormacpayne, can you take a look at this? A while back, I added a property to the build.proj to stop on errors, but the script was not actually throwing and error. This fixes that.

maddieclayton · 2017-12-05T01:35:53Z

@twitchax ping me when you're ready for me to review it

twitchax · 2017-12-05T11:17:13Z

@maddieclayton, probably good to go after build.

twitchax · 2017-12-06T00:34:53Z

@maddieclayton, ok! I manually fixed for the psm1: no reason not to, in my opinion. The rest of the psd1 has stuff that depends on the build placing the files in the right places.

maddieclayton · 2017-12-06T01:01:04Z

src/ResourceManager/Websites/AzureRM.Websites.Netcore.psd1

@@ -9,7 +9,7 @@
 @{

 # Script module or binary module file associated with this manifest.
-# RootModule = ''
+RootModule = '.\AzureRM.Websites.Netcore.psm1'


I don't think this is the way we want to do it - when I asked Mark he said this would make debugging more difficult. I'll try to figure out a better way to do this in the build.proj file

@maddieclayton and @markcowl, what are the debug issues? Maybe it's Netcore, but I can debug just fine the way it is. What problems does this cause on desktop?

Also, this makes dynamic completers work without having to do a bunch of changes/fixes to UpdateModules and PublishModules.

@twitchax see my new PR - this should fix the issue (I also added you as a reviewer)

maddieclayton · 2017-12-06T18:09:40Z

build.proj

      <Artifacts Include="@(GetAllFiles->'%(RootDir)%(Directory)'->Distinct())" />
    </ItemGroup>

    <RemoveDir Directories="%(Artifacts.Identity)" ContinueOnError="true" />

+    <!-- How did these even get here? -->


Did you mean to leave this comment in?

maddieclayton · 2017-12-06T18:12:53Z

src/ResourceManager/Compute/AzureRM.Compute.Netcore.psd1

@@ -9,7 +9,7 @@
 @{

 # Script module or binary module file associated with this manifest.
-# RootModule = ''
+RootModule = '.\AzureRM.Compute.Netcore.psm1'


I'm going to make this happen in the UpdateModule.ps1 script. I'll add you as a reviewer and if it looks good to you we can delete it from here.

Kept this for now based on discussion today.

maddieclayton · 2017-12-06T18:14:25Z

src/ResourceManager/Compute/Commands.Compute/Commands.Compute.Netcore.csproj

@@ -182,4 +183,8 @@
    <Folder Include="VhdManagement\Model\Persistance\" />
  </ItemGroup>

+  <ItemGroup>
+    <Content Include="help\**\*" CopyToPublishDirectory="PreserveNewest" />


Why CopyToPublishDirectory and not CopyToOutputDirectory? Just curious. Also, is there a reason you don't implement it exactly as it is done in the non-netcore csproj files?

Genius! My bad.

maddieclayton · 2017-12-06T19:57:13Z

src/ResourceManager/Websites/AzureRM.Websites.Netcore.psd1

@@ -9,7 +9,7 @@
 @{

 # Script module or binary module file associated with this manifest.
-# RootModule = ''
+RootModule = '.\AzureRM.Websites.Netcore.psm1'


@twitchax see my new PR - this should fix the issue (I also added you as a reviewer)

maddieclayton · 2017-12-06T19:59:30Z

tools/UpdateModules.ps1

@@ -265,31 +265,34 @@ if ($Profile -eq "Stack")
 }

 $resourceManagerRootFolder = "$packageFolder\$buildConfig\ResourceManager\AzureResourceManager"
-$publishToLocal = test-path $repositoryLocation


Why did you delete this?

No action based on discussion today.

cormacpayne · 2017-12-12T00:21:55Z

@azuresdkci test this please

hovsepm · 2017-12-12T21:51:53Z

src/ResourceManager/Storage/AzureRM.Storage.Netcore.psd1

-    'netcoreapp2.0\Microsoft.WindowsAzure.Storage.dll',
-    'netcoreapp2.0\System.Spatial.dll'
+RequiredAssemblies = '.\Microsoft.Azure.Management.Storage.dll',
+    '.\Microsoft.Data.Edm.dll',


FYI, "." paths were not working in Linux in one of the beta builds. Please make sure this will note break Linux modules.

This was fixed, and it works perfectly fine in linux. :)

twitchax · 2017-12-13T04:54:44Z

@cormacpayne, this should be ready. :)

twitchax · 2017-12-14T21:33:58Z

@cormacpayne, ping. :)

twitchax requested a review from cormacpayne December 1, 2017 09:52

azuresdkci added the needs-review label Dec 1, 2017

azuresdkci assigned cormacpayne Dec 1, 2017

twitchax force-pushed the preview branch 2 times, most recently from 4bcd3c5 to e35a62d Compare December 4, 2017 07:51

twitchax changed the title ~~Fail the build if a cmdlet does not have doc mapping.~~ Doc mapping and Netcore fixes. Dec 4, 2017

twitchax force-pushed the preview branch from 9b980f2 to ceaeef0 Compare December 4, 2017 10:51

markcowl assigned maddieclayton and unassigned cormacpayne Dec 4, 2017

twitchax force-pushed the preview branch from 12660ed to c39144b Compare December 5, 2017 11:16

twitchax changed the title ~~Doc mapping and Netcore fixes.~~ Netcore fixes. Dec 5, 2017

Netcore build fixes.

3618743

twitchax force-pushed the preview branch from 054ef1f to 3618743 Compare December 6, 2017 00:31

maddieclayton reviewed Dec 6, 2017

View reviewed changes

markcowl changed the base branch from preview to release-5.1.0 December 6, 2017 02:28

Fix for resources.

4c8a54c

maddieclayton reviewed Dec 6, 2017

View reviewed changes

maddieclayton assigned twitchax and unassigned maddieclayton Dec 6, 2017

maddieclayton added needs-revision and removed needs-review labels Dec 6, 2017

twitchax added 4 commits December 7, 2017 01:33

Merge.

5445007

Fix merge miss.

01edb2c

Fix for build.

3813e7e

Make the build a bit simpler.

84473f4

twitchax added needs-review and removed needs-revision labels Dec 7, 2017

twitchax requested a review from markcowl December 7, 2017 10:38

twitchax assigned cormacpayne and unassigned twitchax Dec 7, 2017

twitchax requested a review from hovsepm December 7, 2017 10:38

Update Netcore psd1.

7327bec

maddieclayton changed the base branch from release-5.1.0 to preview December 9, 2017 01:32

Merge branch 'preview' into preview

15b94d4

hovsepm reviewed Dec 12, 2017

View reviewed changes

cormacpayne approved these changes Dec 15, 2017

View reviewed changes

cormacpayne merged commit 56d3da4 into Azure:preview Dec 15, 2017

Netcore fixes. #5063

Netcore fixes. #5063

Uh oh!

Conversation

twitchax commented Dec 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maddieclayton commented Dec 1, 2017

Uh oh!

twitchax commented Dec 3, 2017

Uh oh!

maddieclayton commented Dec 5, 2017

Uh oh!

twitchax commented Dec 5, 2017

Uh oh!

twitchax commented Dec 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cormacpayne commented Dec 12, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

twitchax commented Dec 13, 2017

Uh oh!

twitchax commented Dec 14, 2017

Uh oh!

Uh oh!

twitchax commented Dec 1, 2017 •

edited

Loading

twitchax commented Dec 6, 2017 •

edited

Loading