Skip to content

AzureRmKubernetes cmdlets for managed Kubernetes #5087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 65 commits into from
Feb 5, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
6d99f4a
initial Kube scaffold
devigned Nov 27, 2017
8582800
drop the output to the correct directory
devigned Nov 28, 2017
9333b18
add basic working get for kube cluster
devigned Nov 29, 2017
15852ba
wip create kube
devigned Dec 1, 2017
0c1e90e
working new kubernetes with service principal creation
devigned Dec 2, 2017
55e33bd
clean up a bit
devigned Dec 2, 2017
8bfb259
add the remove cmdlet
devigned Dec 2, 2017
9f913af
wip aks get-credentials; just need to merge kube config
devigned Dec 4, 2017
8bae7fb
add tests for kube config merging
devigned Dec 5, 2017
6eef836
added should process and tested merge functionality
devigned Dec 6, 2017
5e2a60d
starts a proxy to the dashboard, but does not open with browser on ht…
devigned Dec 6, 2017
ae9a91d
improve browser pop and tunnel process clean up
devigned Dec 6, 2017
c02f279
Port Kubernetes project to desktop
cormacpayne Dec 6, 2017
034d23b
Fix import issue with module, generate markdown help files
cormacpayne Dec 6, 2017
41ea57a
add models to insulate API and add Set cmdlet
devigned Dec 9, 2017
87b717d
regenerate help
devigned Dec 9, 2017
49c699e
update the doc descriptions, inputs and outputs -- generally make the…
devigned Dec 9, 2017
3b852bd
add passthru to cmdlets that will not return something in all contexts
devigned Dec 11, 2017
9c068da
add help for generating an ssh key
devigned Dec 11, 2017
e4a8098
live tests will execute via dotnet test, but runspace fails due to ht…
devigned Dec 14, 2017
0509a4a
desktop projects build again
devigned Dec 19, 2017
3324793
cleaning up desktop projects a bit
devigned Dec 20, 2017
61ec008
add app.config
devigned Dec 20, 2017
bde610d
update help based on feedback
devigned Dec 20, 2017
d4cd3fa
address pull request feedback
devigned Dec 20, 2017
4661d1e
remove nuget config from Kube proj
devigned Dec 20, 2017
ea2fdcd
addressing pr feedback
devigned Dec 20, 2017
d8c1001
rename classes because... standards
devigned Dec 20, 2017
0e6de1b
remove nullable for NodeOsDiskSize
devigned Dec 20, 2017
69023cd
add sshkeypath alias
devigned Dec 20, 2017
fce52dd
add if block braces
devigned Dec 20, 2017
aeb94b5
move back to targetframework rather than targetframeworks
devigned Dec 21, 2017
9b21152
add Kubernetes mapping
devigned Dec 21, 2017
f660cfc
add command line probe and use it to warn user
devigned Dec 22, 2017
c3a9cbc
fix output path and drop load.ps1
devigned Dec 22, 2017
fef7207
added AsJob to new, set and remove
devigned Dec 22, 2017
a5196a1
add example for set and add PSCredential to help
devigned Dec 22, 2017
4615022
fixed the test controller
devigned Dec 22, 2017
5b0dd6a
testing and windows support
devigned Jan 7, 2018
5ffcab9
recorded tests!!
devigned Jan 8, 2018
152b881
remove attribute on base class
devigned Jan 9, 2018
5ba331e
fix jenkins b/c of package is missing
devigned Jan 9, 2018
649e337
add exemptions for Kubernetes name and 2 -Force
devigned Jan 9, 2018
3788cdb
fix probe test to be cross platform
devigned Jan 26, 2018
d766b6d
update the azurerm module ref
devigned Jan 26, 2018
286daa7
use test fixture rather than constructor
devigned Jan 26, 2018
759f712
asserts over basic cluster properties
devigned Jan 26, 2018
e3e30a1
place const at top of method
devigned Jan 26, 2018
571947b
fix feedback items -- now need to figure out how to fix tests
devigned Jan 26, 2018
fedf6b0
remove app.config
devigned Jan 26, 2018
d55bbd4
resolving feedback
devigned Jan 26, 2018
9bf3c89
add prerelease tag
devigned Jan 26, 2018
8752ea1
fix ref to signed yamldotnet
devigned Jan 26, 2018
75374e1
addressing last bit of feedback
devigned Jan 26, 2018
8a6cfc2
Use existing MemoryDataStore if one has been previously instantiated
cormacpayne Jan 27, 2018
3d31133
add file fixtures for tests
devigned Jan 27, 2018
7f97fee
fix the netcore solution from merge conflig
devigned Jan 27, 2018
19d7ff4
add using to the probe test
devigned Jan 27, 2018
61e2a71
remove src and RM folders from netcore sln
devigned Jan 29, 2018
f6873d4
look for YamlDotNet in ./src/packages
devigned Jan 29, 2018
b0d4ea1
Merge branch 'preview' into feature/aks
cormacpayne Jan 30, 2018
2b763f9
Merge branch 'preview' into feature/aks
cormacpayne Jan 31, 2018
d8e1403
Merge branch 'preview' into feature/aks
markcowl Feb 2, 2018
ff1a650
Remove empty line in SignatureIssues.csv
cormacpayne Feb 2, 2018
7cd89fb
Merge branch 'preview' into feature/aks
cormacpayne Feb 3, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -217,3 +217,5 @@ groupMapping*.json
/tools/AutomationTestFramework/TestHelpers/TestHelpers.zip
Results
Package
.DS_Store
.idea
226 changes: 221 additions & 5 deletions Azure.PowerShell.Netcore.sln

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<PropertyGroup>
<TargetFramework>netcoreapp2.0</TargetFramework>
<AssemblyName>Microsoft.Azure.Commands.Common.Authentication.Abstractions</AssemblyName>
<RuntimeIdentifiers>win10-x64</RuntimeIdentifiers>
<RootNamespace>Microsoft.Azure.Commands.Common.Authentication.Abstractions</RootNamespace>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
</PropertyGroup>
Expand All @@ -22,7 +21,7 @@
<DelaySign>false</DelaySign>
</PropertyGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp2.0' ">
<ItemGroup>
<PackageReference Include="Microsoft.Rest.ClientRuntime.Azure.Authentication" Version="2.2.12" />
<PackageReference Include="System.Collections.Specialized" Version="4.3.0" />
<PackageReference Include="System.Reflection" Version="4.3.0" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<PropertyGroup>
<TargetFramework>netcoreapp2.0</TargetFramework>
<AssemblyName>Microsoft.Azure.Commands.Common.Authentication</AssemblyName>
<RuntimeIdentifiers>win10-x64</RuntimeIdentifiers>
<RootNamespace>Microsoft.Azure.Commands.Common.Authentication</RootNamespace>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
</PropertyGroup>
Expand All @@ -22,7 +21,7 @@
<DelaySign>false</DelaySign>
</PropertyGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp2.0' ">
<ItemGroup>
<PackageReference Include="System.Collections.Specialized" Version="4.3.0" />
<PackageReference Include="System.Reflection" Version="4.3.0" />
<PackageReference Include="System.Security.SecureString" Version="4.3.0" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<PropertyGroup>
<TargetFramework>netcoreapp2.0</TargetFramework>
<AssemblyName>Microsoft.Azure.Commands.Common.Authorization</AssemblyName>
<RuntimeIdentifiers>win10-x64</RuntimeIdentifiers>
<RootNamespace>Microsoft.Azure.Commands.Common.Authorization</RootNamespace>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
</PropertyGroup>
Expand All @@ -22,7 +21,7 @@
<DelaySign>false</DelaySign>
</PropertyGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp2.0' ">
<ItemGroup>
<PackageReference Include="System.Collections.Specialized" Version="4.3.0" />
<PackageReference Include="System.Reflection" Version="4.3.0" />
<PackageReference Include="System.Security.SecureString" Version="4.3.0" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<PropertyGroup>
<TargetFramework>netcoreapp2.0</TargetFramework>
<AssemblyName>Microsoft.Azure.Commands.Common.Graph.RBAC</AssemblyName>
<RuntimeIdentifiers>win10-x64</RuntimeIdentifiers>
<RootNamespace>Microsoft.Azure.Commands.Common.Graph.RBAC</RootNamespace>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
</PropertyGroup>
Expand All @@ -22,7 +21,7 @@
<DelaySign>false</DelaySign>
</PropertyGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp2.0' ">
<ItemGroup >
<PackageReference Include="System.Collections.Specialized" Version="4.3.0" />
<PackageReference Include="System.Reflection" Version="4.3.0" />
<PackageReference Include="System.Security.SecureString" Version="4.3.0" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<PropertyGroup>
<TargetFramework>netcoreapp2.0</TargetFramework>
<AssemblyName>Microsoft.Azure.Commands.Common.Network</AssemblyName>
<RuntimeIdentifiers>win10-x64</RuntimeIdentifiers>
<RootNamespace>Microsoft.Azure.Commands.Common.Network</RootNamespace>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
</PropertyGroup>
Expand All @@ -22,7 +21,7 @@
<DelaySign>false</DelaySign>
</PropertyGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp2.0' ">
<ItemGroup >
<PackageReference Include="System.Collections.Specialized" Version="4.3.0" />
<PackageReference Include="System.Reflection" Version="4.3.0" />
<PackageReference Include="System.Security.SecureString" Version="4.3.0" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<PropertyGroup>
<TargetFramework>netcoreapp2.0</TargetFramework>
<AssemblyName>Microsoft.WindowsAzure.Commands.Common.Storage</AssemblyName>
<RuntimeIdentifiers>win10-x64</RuntimeIdentifiers>
<RootNamespace>Microsoft.WindowsAzure.Commands.Common.Storage</RootNamespace>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
</PropertyGroup>
Expand All @@ -22,7 +21,7 @@
<DelaySign>false</DelaySign>
</PropertyGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp2.0' ">
<ItemGroup>
<PackageReference Include="Microsoft.Rest.ClientRuntime.Azure.Authentication" Version="2.2.12" />
<PackageReference Include="Microsoft.Azure.Management.Storage" Version="6.5.0-preview" />
<PackageReference Include="WindowsAzure.Storage" Version="8.1.1" />
Expand Down
21 changes: 21 additions & 0 deletions src/Common/Commands.Common.Tests/Commands.Common.Tests.csproj
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netcoreapp2.0</TargetFramework>

<IsPackable>false</IsPackable>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.5.0" />
<PackageReference Include="xunit" Version="2.3.1" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.3.1" />
<DotNetCliToolReference Include="dotnet-xunit" Version="2.3.1" />
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\..\ResourceManager\Common\Commands.ScenarioTests.ResourceManager.Common\Common.ResourceManager.ScenarioTests.Netcore.csproj" />
<ProjectReference Include="..\Commands.Common\Common.Netcore.csproj" />
</ItemGroup>

</Project>
66 changes: 66 additions & 0 deletions src/Common/Commands.Common.Tests/ProbeTests.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
using Microsoft.WindowsAzure.Commands.ScenarioTest;
using Microsoft.WindowsAzure.Commands.Utilities.Common;
using System;
using System.Linq;
using System.Runtime.InteropServices;
using Xunit;

namespace Commands.Common.Tests
{
public class ProbeTests
{
private readonly string _pwsh;

public ProbeTests()
{
_pwsh = RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? "powershell" : "pwsh";
}

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
public void FalseWhenProgramDoesNotExistTest()
{
Assert.False(GeneralUtilities.Probe("foo"));
}

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
public void TrueWhenProgramDoesExistTest()
{
Assert.True(GeneralUtilities.Probe(_pwsh, " -c 'echo hello world!'"));
}

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
public void FailIfStdOutDoesNotMatchTest()
{
Assert.False(
GeneralUtilities.Probe(
_pwsh, " -c 'echo foo'",
criterion: (processExitInfo) =>
{
return processExitInfo.StdOut.Any(x => x.Contains("bar"));
}));
}

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
public void TrueIfStdOutDoesMatchTest()
{
Assert.True(
GeneralUtilities.Probe(
_pwsh, " -c 'echo foo'",
criterion: (processExitInfo) =>
{
return processExitInfo.StdOut.Any(x => x.Contains("foo"));
}));
}

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
public void FailIfProcessTakesTooLongToRespondTest()
{
Assert.False(GeneralUtilities.Probe(_pwsh, "-c \"sleep 4\""));
}
}
}
3 changes: 1 addition & 2 deletions src/Common/Commands.Common/Common.Netcore.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<PropertyGroup>
<TargetFramework>netcoreapp2.0</TargetFramework>
<AssemblyName>Microsoft.WindowsAzure.Commands.Common</AssemblyName>
<RuntimeIdentifiers>win10-x64</RuntimeIdentifiers>
<RootNamespace>Microsoft.WindowsAzure.Commands.Common</RootNamespace>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
Expand All @@ -23,7 +22,7 @@
<DelaySign>false</DelaySign>
</PropertyGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp2.0' ">
<ItemGroup >
<PackageReference Include="System.Collections.NonGeneric" Version="4.3.0" />
<PackageReference Include="System.Net.WebHeaderCollection" Version="4.3.0" />
<PackageReference Include="System.Management.Automation" Version="6.0.0-rc" />
Expand Down
68 changes: 68 additions & 0 deletions src/Common/Commands.Common/Utilities/GeneralUtilities.cs
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,74 @@ public static void ClearCurrentStorageAccount(bool clearSMContext = false)
}
#endif
}

/// <summary>
/// Execute a process and check for a clean exit to determine if the process exists.
/// </summary>
/// <param name="programName">Name of the program to start.</param>
/// <param name="args">Command line argumentes provided to the program.</param>
/// <param name="waitTime">Time to wait for the process to close.</param>
/// <param name="criterion">Function to evaluate the process response to determine success. The default implementation returns true if the exit code equals 0.</param>
/// <returns></returns>
public static bool Probe(string programName, string args = "", int waitTime = 3000, Func<ProcessExitInfo, bool> criterion = null)
{
try
{
var process = new Process
{
StartInfo = new ProcessStartInfo
{
FileName = programName,
Arguments = args,
RedirectStandardOutput = true,
RedirectStandardError = true,
UseShellExecute = false
}
};
var stdout = new List<string>();
var stderr = new List<string>();
process.OutputDataReceived += (s, e) => stdout.Add(e.Data);
process.ErrorDataReceived += (s, e) => stderr.Add(e.Data);
process.Start();
process.BeginErrorReadLine();
process.BeginOutputReadLine();
process.WaitForExit(waitTime);
var exitInfo = new ProcessExitInfo { ExitCode = process.ExitCode, StdOut = stdout, StdErr = stderr };
var exitCode = process.ExitCode;
return criterion == null ? exitInfo.ExitCode == 0 : criterion(exitInfo);
}
catch (InvalidOperationException)
{
// The excutable failed to execute prior wait time expiring.
return false;
}
catch (SystemException)
{
// The excutable doesn't exist on path. Rather than handling Win32 exception, chose to handle a less platform specific sys exception.
return false;
}
}

/// <summary>
/// Process exit information
/// </summary>
public class ProcessExitInfo
{
/// <summary>
/// Exit code of a process
/// </summary>
public int ExitCode { get; set; }

/// <summary>
/// List of all lines from STDOUT
/// </summary>
public IList<string> StdOut { get; set; }

/// <summary>
/// List of all lines from STDERR
/// </summary>
public IList<string> StdErr { get; set; }
}

public static string DownloadFile(string uri)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<PropertyGroup>
<TargetFramework>netcoreapp2.0</TargetFramework>
<AssemblyName>Microsoft.Azure.Commands.Common.Authentication.ResourceManager</AssemblyName>
<RuntimeIdentifiers>win10-x64</RuntimeIdentifiers>
<RootNamespace>Microsoft.Azure.Commands.Common.Authentication.ResourceManager</RootNamespace>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
</PropertyGroup>
Expand All @@ -22,7 +21,7 @@
<DelaySign>false</DelaySign>
</PropertyGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp2.0' ">
<ItemGroup >
<PackageReference Include="Microsoft.Rest.ClientRuntime.Azure.Authentication" Version="2.2.12" />
<PackageReference Include="Microsoft.Rest.ClientRuntime.Azure" Version="3.3.8" />
<PackageReference Include="System.Collections.NonGeneric" Version="4.3.0" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<PropertyGroup>
<TargetFramework>netcoreapp2.0</TargetFramework>
<AssemblyName>Microsoft.Azure.Commands.Common.Strategies</AssemblyName>
<RuntimeIdentifiers>win10-x64</RuntimeIdentifiers>
<RootNamespace>Microsoft.Azure.Commands.Common.Strategies</RootNamespace>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
</PropertyGroup>
Expand All @@ -22,7 +21,7 @@
<DelaySign>false</DelaySign>
</PropertyGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp2.0' ">
<ItemGroup>
<PackageReference Include="Microsoft.Azure.Management.ResourceManager" Version="1.6.0-preview" />
<PackageReference Include="Microsoft.Azure.Management.Compute" Version="16.3.0" />
<PackageReference Include="Microsoft.Azure.Management.Network" Version="10.1.0-preview" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<PropertyGroup>
<TargetFramework>netcoreapp2.0</TargetFramework>
<AssemblyName>Microsoft.Azure.Commands.ResourceManager.Common</AssemblyName>
<RuntimeIdentifiers>win10-x64</RuntimeIdentifiers>
<RootNamespace>Microsoft.Azure.Commands.ResourceManager.Common</RootNamespace>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
</PropertyGroup>
Expand All @@ -22,7 +21,7 @@
<DelaySign>false</DelaySign>
</PropertyGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp2.0' ">
<ItemGroup>
<PackageReference Include="Microsoft.Rest.ClientRuntime.Azure.Authentication" Version="2.2.12" />
<PackageReference Include="Microsoft.Rest.ClientRuntime.Azure" Version="3.3.8" />
<PackageReference Include="System.Collections.NonGeneric" Version="4.3.0" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

<PropertyGroup>
<TargetFramework>netcoreapp2.0</TargetFramework>
<RuntimeIdentifiers>win10-x64</RuntimeIdentifiers>
<AssemblyName>Microsoft.Azure.Commands.ScenarioTest.Common</AssemblyName>
<RootNamespace>Microsoft.Azure.Commands.ScenarioTest</RootNamespace>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,12 @@ public class EnvironmentSetupHelper
public EnvironmentSetupHelper()
{
TestExecutionHelpers.SetUpSessionAndProfile();
var datastore = new MemoryDataStore();
IDataStore datastore = new MemoryDataStore();
if (AzureSession.Instance.DataStore != null && (AzureSession.Instance.DataStore is MemoryDataStore))
{
datastore = AzureSession.Instance.DataStore;
}

AzureSession.Instance.DataStore = datastore;
var rmprofile = new AzureRmProfile(Path.Combine(AzureSession.Instance.ProfileDirectory, AzureSession.Instance.ProfileFile));
rmprofile.EnvironmentTable.Add("foo", new AzureEnvironment(AzureEnvironment.PublicEnvironments.Values.FirstOrDefault()));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

<PropertyGroup>
<TargetFramework>netcoreapp2.0</TargetFramework>
<RuntimeIdentifiers>win10-x64</RuntimeIdentifiers>
<AssemblyName>Microsoft.Azure.Commands.Compute</AssemblyName>
<RootNamespace>Microsoft.Azure.Commands.Compute</RootNamespace>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
Expand All @@ -27,7 +26,7 @@
<DefineConstants>TRACE;RELEASE;NETSTANDARD;SIGN</DefineConstants>
</PropertyGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp2.0' ">
<ItemGroup >
<PackageReference Include="Microsoft.Azure.Management.ResourceManager" Version="1.6.0-preview" />
<PackageReference Include="Microsoft.Azure.Graph.RBAC" Version="3.4.0-preview" />
<PackageReference Include="Microsoft.Azure.Management.Authorization" Version="2.5.0-preview" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

<PropertyGroup>
<TargetFramework>netcoreapp2.0</TargetFramework>
<RuntimeIdentifiers>win10-x64</RuntimeIdentifiers>
<AssemblyName>Microsoft.Azure.Commands.KeyVault</AssemblyName>
<RootNamespace>Microsoft.Azure.Commands.KeyVault</RootNamespace>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
Expand All @@ -28,7 +27,7 @@
<DefineConstants>TRACE;RELEASE;NETSTANDARD;SIGN</DefineConstants>
</PropertyGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp2.0' ">
<ItemGroup>
<PackageReference Include="Microsoft.Azure.KeyVault" Version="2.3.2" />
<PackageReference Include="Microsoft.Azure.KeyVault.WebKey" Version="2.0.7" />
<PackageReference Include="Microsoft.Azure.Management.KeyVault" Version="2.3.0-preview" />
Expand Down
Loading