Add a VHD DiskFile parameter set to existing New-AzureRmVM cmdlet #5105

huangpf · 2017-12-08T00:31:37Z

Description

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

I have read the contribution guidelines.
If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

Pull request includes test coverage for the included changes.
PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

hyonholee · 2017-12-08T00:37:31Z

...ourceManager/Compute/Commands.Compute.ManagedService/StorageServices/NewAzureVhdVMCommand.cs

+        [Parameter(ParameterSetName = DiskFileParameterSetNameStr, Mandatory = false, Position = 9, ValueFromPipelineByPropertyName = true)]
+        [ValidateNotNullOrEmpty]
+        [ValidateRange(1, 64)]
+        public int? NumberOfUploaderThreads { get; set; }


int, instead of int?

int will default to 0... but we want to set default to 2 if no value is specified, i.e. null.

hyonholee · 2017-12-08T00:37:49Z

...ourceManager/Compute/Commands.Compute.ManagedService/StorageServices/NewAzureVhdVMCommand.cs

+
+        [Parameter(ParameterSetName = DiskLinkParameterSetNameStr, Mandatory = false, Position = 10, ValueFromPipelineByPropertyName = true)]
+        [Parameter(ParameterSetName = DiskFileParameterSetNameStr, Mandatory = false, Position = 10, ValueFromPipelineByPropertyName = true)]
+        public bool? CheckDiskLinkExistence { get; set; }


consider switch parameter

hyonholee · 2017-12-08T00:38:46Z

...ourceManager/Compute/Commands.Compute.ManagedService/StorageServices/NewAzureVhdVMCommand.cs

+        [Parameter(ParameterSetName = DiskLinkParameterSetNameStr, Mandatory = false, Position = 6, ValueFromPipelineByPropertyName = true)]
+        [Parameter(ParameterSetName = DiskFileParameterSetNameStr, Mandatory = false, Position = 6, ValueFromPipelineByPropertyName = true)]
+        [ValidateNotNullOrEmpty]
+        public List<SecurityRule> SecurityRules { get; set; }


array instead of List

hyonholee · 2017-12-08T00:39:11Z

...ourceManager/Compute/Commands.Compute.ManagedService/StorageServices/NewAzureVhdVMCommand.cs

+using Microsoft.WindowsAzure.Storage;
+using Microsoft.WindowsAzure.Storage.Auth;
+using Microsoft.WindowsAzure.Storage.Blob;
+using System.Collections.Generic;


NIT: sort usings.

hyonholee · 2017-12-08T00:40:39Z

...urceManager/Resources/Commands.Resources/RoleAssignments/RemoveAzureRoleAssignmentCommand.cs

@@ -153,7 +153,7 @@ public class RemoveAzureRoleAssignmentCommand : ResourcesBaseCmdlet
        public SwitchParameter PassThru { get; set; }

        [ValidateNotNullOrEmpty]
-        [Parameter(Position = 0, Mandatory = true, ValueFromPipeline = true, ParameterSetName = ParameterSet.RoleAssignment, HelpMessage = "Role Assignment.")]
+        [Parameter(Position = 0, Mandatory = true, ValueFromPipeline = true, ParameterSetName = "RoleAssignment", HelpMessage = "Role Assignment.")]


is this change necessary?

I have to make this change, because it's breaking my build.

Please revert all ofthese changes outside the Compute project

hyonholee · 2017-12-08T00:46:37Z

...ourceManager/Compute/Commands.Compute.ManagedService/StorageServices/NewAzureVhdVMCommand.cs

+        [Parameter(ParameterSetName = DiskLinkParameterSetNameStr, Mandatory = true, Position = 1, ValueFromPipelineByPropertyName = true)]
+        [Parameter(ParameterSetName = DiskFileParameterSetNameStr, Mandatory = true, Position = 1, ValueFromPipelineByPropertyName = true)]
+        [ValidateNotNullOrEmpty]
+        public string Location { get; set; }


Consider adding Zone parameter too.

It's for a single VM. Does a Zone parameter help?

If so, how?

hyonholee · 2017-12-08T00:48:12Z

src/ResourceManager/Compute/Commands.Compute.ManagedService/help/New-AzureRmVhdVM.md

+```
+
+### -VMSize
+Fill VMSize Description


in the help file, please indicate the default value when the parameter is not given.

hyonholee · 2017-12-08T00:53:54Z

src/ResourceManager/Compute/Commands.Compute/Commands.Compute.csproj

@@ -64,9 +64,16 @@
      <HintPath>..\..\..\packages\Microsoft.Azure.Management.KeyVault.2.3.0-preview\lib\net452\Microsoft.Azure.Management.KeyVault.dll</HintPath>
      <Private>True</Private>
    </Reference>
+    <Reference Include="Microsoft.Azure.Management.Network, Version=15.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">


do you need to update commands.compute project?

hyonholee · 2017-12-08T00:59:07Z

remove files under stackadmin and tools directory.

markcowl · 2017-12-20T01:44:12Z

src/ResourceManager/Compute/AzureRM.Compute.ManagedService-help.xml

@@ -0,0 +1,3 @@
+<?xml version="1.0" encoding="utf-8"?>


markcowl · 2017-12-20T01:44:43Z

src/ResourceManager/Compute/AzureRM.Compute.ManagedService.psd1

@@ -0,0 +1,126 @@
+#


This should be in its own directory (Compute.ManagedService)

They were in different folders from the initial commits...

markcowl · 2017-12-20T01:44:56Z

src/ResourceManager/Compute/AzureRM.Compute.ManagedService.psd1

+# ProcessorArchitecture = ''
+
+# Modules that must be imported into the global environment prior to importing this module
+RequiredModules = @(@{ModuleName = 'AzureRM.Profile'; ModuleVersion = '4.0.0'; })


markcowl · 2017-12-20T01:47:16Z

...sourceManager/Compute/Commands.Compute.ManagedService/Commands.Compute.ManagedService.csproj

+      <Private>True</Private>
+    </Reference>
+    <Reference Include="Microsoft.Azure.Management.Network, Version=15.1.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
+      <HintPath>..\..\..\packages\Microsoft.Azure.Management.Network.15.1.0-preview\lib\net452\Microsoft.Azure.Management.Network.dll</HintPath>


This package should not take dependencies on any management clients other than Compute. Any required management operations should come from the Commands.Common.* common assembleis. This prevents modules from taking dependencies on incompatible versions of shared assemblies.

markcowl · 2017-12-20T01:47:38Z

...sourceManager/Compute/Commands.Compute.ManagedService/Commands.Compute.ManagedService.csproj

+      <HintPath>..\..\..\packages\Microsoft.Azure.Management.Resources.2.20.0-preview\lib\portable-net45+wp8+wpa81+win\Microsoft.Azure.ResourceManager.dll</HintPath>
+    </Reference>
+    <Reference Include="Microsoft.Data.Edm, Version=5.8.1.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
+      <HintPath>..\..\..\packages\Microsoft.Data.Edm.5.8.2\lib\net40\Microsoft.Data.Edm.dll</HintPath>


Is WindowsAzure.Storage sued for this?

markcowl · 2017-12-20T01:54:38Z

...ourceManager/Compute/Commands.Compute.ManagedService/StorageServices/NewAzureVhdVMCommand.cs

+
+        [Parameter(ParameterSetName = DiskLinkParameterSetNameStr, Mandatory = false, Position = 9, ValueFromPipelineByPropertyName = true)]
+        [Parameter(ParameterSetName = DiskFileParameterSetNameStr, Mandatory = false, Position = 9, ValueFromPipelineByPropertyName = true)]
+        [ValidateNotNullOrEmpty]


As discussed, why do we need this parameter?

markcowl · 2017-12-20T01:54:58Z

...ourceManager/Compute/Commands.Compute.ManagedService/StorageServices/NewAzureVhdVMCommand.cs

+
+        [Parameter(ParameterSetName = DiskLinkParameterSetNameStr, Mandatory = false, Position = 10, ValueFromPipelineByPropertyName = true)]
+        [Parameter(ParameterSetName = DiskFileParameterSetNameStr, Mandatory = false, Position = 10, ValueFromPipelineByPropertyName = true)]
+        public SwitchParameter NoDiskLinkExistenceCheck { get; set; }


SkipDiskLinkExistenceCheck

markcowl · 2017-12-20T01:57:59Z

src/ResourceManager/Compute/Commands.Compute.ManagedService/Tools/Move-AzureRmVhdVM.ps1

+#>
+
+function Move-AzureRmVhdVM
+{


I don't think we have figured out how to take the necessary depencency, or whether this shoudl be a cmdlet or a script

markcowl · 2017-12-20T01:58:17Z

src/ResourceManager/Compute/Commands.Compute.ManagedService/help/New-AzureRmVhdVM.md

+```
+
+## DESCRIPTION
+Fill in the Description


Please fill out the help data

markcowl · 2017-12-20T01:59:14Z

...urceManager/Resources/Commands.Resources/RoleAssignments/RemoveAzureRoleAssignmentCommand.cs

@@ -153,7 +153,7 @@ public class RemoveAzureRoleAssignmentCommand : ResourcesBaseCmdlet
        public SwitchParameter PassThru { get; set; }

        [ValidateNotNullOrEmpty]
-        [Parameter(Position = 0, Mandatory = true, ValueFromPipeline = true, ParameterSetName = ParameterSet.RoleAssignment, HelpMessage = "Role Assignment.")]
+        [Parameter(Position = 0, Mandatory = true, ValueFromPipeline = true, ParameterSetName = "RoleAssignment", HelpMessage = "Role Assignment.")]


Please revert all ofthese changes outside the Compute project

maddieclayton · 2017-12-23T00:04:23Z

@azuresdkci Test this please

hyonholee · 2018-01-11T21:40:41Z

src/ResourceManager/Compute/Commands.Compute/Strategies/Compute/VirtualMachineStrategy.cs

@@ -31,7 +31,7 @@ static class VirtualMachineStrategy
                    p.ResourceGroupName, p.Name, null, p.CancellationToken),
                createOrUpdateAsync: (o, p) => o.CreateOrUpdateAsync(
                    p.ResourceGroupName, p.Name, p.Model, p.CancellationToken),
-                createTime: c => c.OsProfile.WindowsConfiguration != null ? 240 : 120);
+                createTime: c => c.OsProfile == null ? 240 : c.OsProfile.WindowsConfiguration != null ? 240 : 120);


Do not use nested ? :
Combine two conditions or use if-then-else.

This is a lamda expression, so I just want to fit it into one line...

Anyway, I will try not to use nested here.

hyonholee · 2018-01-11T21:41:07Z

src/ResourceManager/Compute/Commands.Compute/Strategies/Compute/ManagedDiskStrategy.cs

+using Microsoft.Azure.Management.Compute;
+using Microsoft.Azure.Management.Compute.Models;
+using Microsoft.Azure.Management.Internal.Resources.Models;
+using Microsoft.Azure.Commands.Compute.Strategies.ResourceManager;


NIT: order usings.

hyonholee · 2018-01-11T21:45:27Z

src/ResourceManager/Compute/Commands.Compute/VirtualMachine/Operation/NewAzureVMCommand.cs

        public string Size { get; set; } = "Standard_DS1_v2";
-
+        


NIT: unnecessary spaces

hyonholee · 2018-01-11T21:48:36Z

src/ResourceManager/Compute/Commands.Compute/VirtualMachine/Operation/NewAzureVMCommand.cs

+
+        [Parameter(ParameterSetName = DiskFileParameterSet, Mandatory = true)]
+        [ValidateNotNullOrEmpty]
+        public string DiskFile { get; set; }


You need to update \help\New-AzureRmVM.md file for new parameters.

Can we add this parameter to the SimpleSarameterSet instead of creating a new parameter set?

Then the parameter set would be mixed for image & disk file cases. I don't think it's actually a good way to do so. We may expand the DiskFile set later on, as well.

huangpf · 2018-01-11T22:47:54Z

src/ResourceManager/Compute/Commands.Compute/VirtualMachine/Operation/NewAzureVMCommand.cs

+                    Cmdlet = this,
+                    BlobObjectFactory = new CloudPageBlobObjectFactory(storageCredentialsFactory, TimeSpan.FromMinutes(1))
+                };
+                if (!string.Equals(Environment.GetEnvironmentVariable("AZURE_TEST_MODE"), "playback", StringComparison.OrdinalIgnoreCase))


@markcowl @hyonholee
Is it OK to do so?

hmm.. I don't think this should be in dev code.

This is to increase testability & I think I somehow saw similar code somewhere.

hyonholee · 2018-01-11T23:04:24Z

src/ResourceManager/Compute/Commands.Compute/help/New-AzureRmVM.md

+```
+
+### -DiskFile
+{{Fill DiskFile Description}}


Add description

hyonholee · 2018-01-11T23:04:49Z

src/ResourceManager/Compute/Commands.Compute/help/New-AzureRmVM.md

@@ -248,30 +273,45 @@ Accept pipeline input: False
 Accept wildcard characters: False
 ```

+### -Linux
+{{Fill Linux Description}}


Fill the description

markcowl · 2018-01-12T17:01:29Z

src/ResourceManager/Compute/Commands.Compute.Test/ScenarioTests/NewVhdVMTests.ps1

+        $thrownErrorMessage = '';
+        try
+        {
+            $st = New-AzureRmVM -ResourceGroupName $rgname -Name $rgname -Location $loc -DiskFile $file;


I don't understand - you are catching an exception when this is supposed to be a positive test case. You are also not testing any properties of the VM. Please include an actual positive test case in which you create a valid VM and validate the expected properties of the resulting object.

I'm puzzled by the test framework as well, as you can see in the checkpoint in the next few lines, the test will fail with either 'queue empty' or 'object not found' errors only in playback mode.

markcowl · 2018-01-12T17:01:56Z

Azure.PowerShell.Netcore.sln

@@ -1,50 +1,52 @@

 Microsoft Visual Studio Solution File, Format Version 12.00
 # Visual Studio 15
-VisualStudioVersion = 15.0.27019.1
+VisualStudioVersion = 15.0.27130.2010


Why is this file changed? Did we need to add in the strategies project?

The netcore build failed, so I had to do something with it, but maybe it's not needed to change the solution file. I will try to revert this particular part and see.

sergey-shandar

I would like to discuss if we can use Strategies for disks as well as for other resources.

sergey-shandar · 2018-01-12T19:49:38Z

src/ResourceManager/Compute/Commands.Compute/Strategies/Compute/ManagedDiskStrategy.cs

+                    p.ResourceGroupName, p.Name, p.CancellationToken),
+                createOrUpdateAsync: (o, p) => o.CreateOrUpdateAsync(
+                    p.ResourceGroupName, p.Name, p.Model, p.CancellationToken),
+                createTime: d => 120);


Does it take 2 minutes (120 seconds) in average to create a disk ?

I think it's about right. What would happen the real timespan is more?

We use the number to show progress, it's ok if takes longer or shorter. We need an average.

OK. Should be fine.

sergey-shandar · 2018-01-12T19:52:15Z

src/ResourceManager/Compute/Commands.Compute/Strategies/Compute/VirtualMachineStrategy.cs

+                            Name = disk.Name,
+                            CreateOption = DiskCreateOptionTypes.Attach,
+                            OsType = isWindows ? OperatingSystemTypes.Windows : OperatingSystemTypes.Linux,
+                            ManagedDisk = new ManagedDiskParameters


IMHO, we should modify the existing CreateVirtualMachineConfig and have ResourceConfig<Disk> disk as an optional parameter.

Similar to the other comment.

sergey-shandar · 2018-01-12T19:53:33Z

src/ResourceManager/Compute/Commands.Compute/VirtualMachine/Operation/NewAzureVMCommand.cs


 namespace Microsoft.Azure.Commands.Compute
 {
    [Cmdlet(
        VerbsCommon.New,
        ProfileNouns.VirtualMachine,
        SupportsShouldProcess = true,
-        DefaultParameterSetName = "DefaultParameterSet")]
+        DefaultParameterSetName = "SimpleParameterSet")]
    [OutputType(typeof(PSAzureOperationResponse), typeof(PSVirtualMachine))]


IMHO, we should still use DefaultParameterSet as default.

The parameter set with the least inputs should be the default, otherwise PS is not able to resolve which set the users want to use.

sergey-shandar · 2018-01-12T19:55:00Z

src/ResourceManager/Compute/Commands.Compute/VirtualMachine/Operation/NewAzureVMCommand.cs

+
+        [Parameter(ParameterSetName = DiskFileParameterSet, Mandatory = true)]
+        [ValidateNotNullOrEmpty]
+        public string DiskFile { get; set; }


Can we add this parameter to the SimpleSarameterSet instead of creating a new parameter set?

sergey-shandar · 2018-01-12T19:56:46Z

src/ResourceManager/Compute/Commands.Compute/VirtualMachine/Operation/NewAzureVMCommand.cs

@@ -176,6 +209,9 @@ public override void ExecuteCmdlet()
                case SimpleParameterSet:
                    this.StartAndWait(StrategyExecuteCmdletAsync);
                    break;
+                case DiskFileParameterSet:
+                    this.StartAndWait(StrategyExecuteCmdletAsync);


The implementation is identical for SimpleParameterSet and DiskFileParameterSet. This confirms that we don't need a new parameter set ;-)

Similar comment.

Yes, we actually need a parameter set to make Image and DiskFile mutually exclusive. Whether we need separate execution paths is a question.

sergey-shandar · 2018-01-12T20:05:39Z

src/ResourceManager/Compute/Commands.Compute/VirtualMachine/Operation/NewAzureVMCommand.cs

+                        AzureSession.Instance.ClientFactory.CreateArmClient<StorageManagementClient>(DefaultProfile.DefaultContext,
+                            AzureEnvironment.Endpoint.ResourceManager);
+                var st1 = storageClient.StorageAccounts.Create(ResourceGroupName, Name, new StorageAccountCreateParameters
+                {


It would be good if call the Create function as a part of dependency tree. I can help with this. In the future, we may generate Azure templates so let's discuss it.

I tried, but not trivial. You can check storage account operations. They don't have Get and they have GetProperties, and they don't have CreateOrUpdate and they use Create, etc.

There is one problem then. A user may specify a new resource group which doesn't exist yet. SimpleParameterSet handles this but it will fail in DiskFileParameterSet.

I think I use the same RG strategy?

this ResourceConfig<ResourceGroup> resourceGroup,

Oh, you mean in the storage creation...

Can we handle it as a bug item? It doesn't seem to be trivial, and it's not an issue for the Simple parameter set, and not a P0 blocker for DiskFile set as well...

I'm fine with this as long as we track the issue.

Created for tracking: #5279

markcowl · 2018-01-13T03:36:13Z

on demand run here: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/powershell-demand/351/

markcowl · 2018-01-13T01:18:51Z

src/ResourceManager/Compute/Commands.Compute/VirtualMachine/Operation/NewAzureVMCommand.cs

@@ -176,6 +209,9 @@ public override void ExecuteCmdlet()
                case SimpleParameterSet:
                    this.StartAndWait(StrategyExecuteCmdletAsync);
                    break;
+                case DiskFileParameterSet:
+                    this.StartAndWait(StrategyExecuteCmdletAsync);


Yes, we actually need a parameter set to make Image and DiskFile mutually exclusive. Whether we need separate execution paths is a question.

Will resolve in separate PR

sergey-shandar

Will it make sense to have another parameterset which accept disk Uri?

sergey-shandar · 2018-01-13T05:45:08Z

src/ResourceManager/Compute/Commands.Compute/VirtualMachine/Operation/NewAzureVMCommand.cs

+                    {
+                        Name = SkuName.PremiumLRS
+                    },
+#endif


Could we create a separate static function? For example

public static StorageAccountCreateParameters WithPremiumLRS(this StorageAccountCreateParameters p) { #if !NETSTANDARD p.AccountType = AccountType.PremiumLRS; #else p.Sku = new SM.Sku { Name = SkuName.PremiumLRS }; #endif return p; }

@sergey-shandar When users give a disk file, & we upload it to the cloud, there should be no lease on it. However, if users directly refer to a disk link, it's not necessarily that case, so we need to think about what's the proper way to validate that. Thus, it's not included in this PR to make things too complicated.

Regarding the macro conditionally separated code, I think we should be able to live with them for a while? Since eventually the Storage client is going to reconcile and use only the final set of input parameters. Then at that time, the static function will need to be removed as well, if they are added now.

sergey-shandar · 2018-01-13T05:45:58Z

src/ResourceManager/Compute/Commands.Compute/VirtualMachine/Operation/NewAzureVMCommand.cs

+                        AzureSession.Instance.ClientFactory.CreateArmClient<StorageManagementClient>(DefaultProfile.DefaultContext,
+                            AzureEnvironment.Endpoint.ResourceManager);
+                var st1 = storageClient.StorageAccounts.Create(ResourceGroupName, Name, new StorageAccountCreateParameters
+                {


I'm fine with this as long as we track the issue.

hyonholee reviewed Dec 8, 2017

View reviewed changes

azuresdkci added the needs-review label Dec 8, 2017

azuresdkci assigned shahabhijeet Dec 8, 2017

huangpf force-pushed the vhd2 branch 3 times, most recently from 72b6451 to e85ba33 Compare December 8, 2017 08:11

cormacpayne assigned markcowl and cormacpayne and unassigned shahabhijeet Dec 12, 2017

huangpf force-pushed the vhd2 branch 2 times, most recently from 7f97618 to d5084bc Compare December 14, 2017 00:43

markcowl unassigned cormacpayne Dec 18, 2017

huangpf force-pushed the vhd2 branch from d5084bc to cfe1400 Compare December 20, 2017 01:25

markcowl requested changes Dec 20, 2017

View reviewed changes

markcowl removed their assignment Dec 20, 2017

markcowl added needs-revision and removed needs-review labels Dec 20, 2017

markcowl assigned huangpf Dec 20, 2017

huangpf force-pushed the vhd2 branch 2 times, most recently from d6e8797 to bad01ab Compare December 20, 2017 05:28

maddieclayton unassigned huangpf Dec 23, 2017

hyonholee reviewed Jan 11, 2018

View reviewed changes

huangpf force-pushed the vhd2 branch 6 times, most recently from 071131a to 0df10c9 Compare January 11, 2018 22:47

huangpf commented Jan 11, 2018

View reviewed changes

hyonholee reviewed Jan 11, 2018

View reviewed changes

huangpf force-pushed the vhd2 branch 3 times, most recently from 666b685 to 290bffb Compare January 12, 2018 00:15

markcowl requested changes Jan 12, 2018

View reviewed changes

huangpf force-pushed the vhd2 branch 2 times, most recently from d566881 to 1865f89 Compare January 12, 2018 18:02

Add a VHD DiskFile parameter set to existing New-AzureRmVM cmdlet

a2345c3

huangpf force-pushed the vhd2 branch from 1865f89 to a2345c3 Compare January 12, 2018 19:14

sergey-shandar previously requested changes Jan 12, 2018

View reviewed changes

markcowl added Waiting for On Demand and removed needs-revision labels Jan 13, 2018

markcowl approved these changes Jan 13, 2018

View reviewed changes

sergey-shandar reviewed Jan 13, 2018

View reviewed changes

sergey-shandar approved these changes Jan 13, 2018

View reviewed changes

markcowl merged commit 4280292 into Azure:preview Jan 16, 2018

Add a VHD DiskFile parameter set to existing New-AzureRmVM cmdlet #5105

Add a VHD DiskFile parameter set to existing New-AzureRmVM cmdlet #5105

Uh oh!

Conversation

huangpf commented Dec 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hyonholee commented Dec 8, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maddieclayton commented Dec 23, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huangpf commented Dec 8, 2017 •

edited

Loading