Skip to content

Removed local NuGet package that was causing build issues for KeyVault on the Stack solution #5139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 6, 2018

Conversation

MiYanni
Copy link
Contributor

@MiYanni MiYanni commented Dec 13, 2017

Description

I found that the Stack solution wasn't building due to a Local version of HttpRecorder. Removing this from the repo allowed this solution to build properly.


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

@markcowl
Copy link
Member

@MiYanni The Travis build is failing not sure if it requires a package in LocalFeed, or if it needs to have the version of the test framework package updated. @hovsepm or @twitchax could help you debug.

@maddieclayton
Copy link
Contributor

@azuresdkci Test this please

@twitchax
Copy link
Contributor

@azuresdkci test this please.

@MiYanni
Copy link
Contributor Author

MiYanni commented Jan 3, 2018

@twitchax Is this ready to merge? I wasn't sure if the PR you made for my branch was all that was needed. It builds now, so I'd think it is ready to go. (Just needs a review approval)

@maddieclayton
Copy link
Contributor

@maddieclayton maddieclayton merged commit af4a016 into Azure:preview Jan 6, 2018
@MiYanni MiYanni deleted the RemoveHttpNuget branch January 8, 2018 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants