-
Notifications
You must be signed in to change notification settings - Fork 4k
Update of WAD schema model classes #5150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ramesh Chander <[email protected]>
Can one of the admins verify this patch? |
Code is tested and working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an automated test that covers this? If not, please ensure thsi is verified manually, and assign yourself a test bug for adding automation.
Also, please update the Changelog for the Comput module to reflect this change
Code is tested manually.
|
@azuresdkci Add to whitelist |
@chhabaramesh 1) Create an issue in our repo for your test debt (example here) and assign it to yourself with your team's label. 2) Update the Compute changelog here in the Current Release section. |
@azuresdkci Test this please |
Changelog: #5186 changelog update. |
@chhabaramesh please add the changelog change to this PR and close the other issue - it is better to keep the two changes together so we don't release one without the other. After that I will reassign to Mark. |
WAD config schema has some new fields that needs update.
Signed-off-by: Ramesh Chander [email protected]
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines