Skip to content

Update of WAD schema model classes #5150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2017
Merged

Conversation

chhabaramesh
Copy link
Contributor

@chhabaramesh chhabaramesh commented Dec 15, 2017

WAD config schema has some new fields that needs update.

Signed-off-by: Ramesh Chander [email protected]

Description


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

@azuresdkci
Copy link

Can one of the admins verify this patch?

@chhabaramesh
Copy link
Contributor Author

Code is tested and working.

Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an automated test that covers this? If not, please ensure thsi is verified manually, and assign yourself a test bug for adding automation.

Also, please update the Changelog for the Comput module to reflect this change

@chhabaramesh
Copy link
Contributor Author

@markcowl

Code is tested manually.

  1. Where do create automation bug? Which tool do you use?
  2. What is compute changelog that I can update? is it just any text file or anything more?

@markcowl markcowl self-assigned this Dec 18, 2017
@maddieclayton
Copy link
Contributor

@azuresdkci Add to whitelist

@maddieclayton
Copy link
Contributor

@chhabaramesh 1) Create an issue in our repo for your test debt (example here) and assign it to yourself with your team's label. 2) Update the Compute changelog here in the Current Release section.

@maddieclayton
Copy link
Contributor

@azuresdkci Test this please

@chhabaramesh
Copy link
Contributor Author

chhabaramesh commented Dec 26, 2017

Changelog: #5186 changelog update.
Issue: #5187
@maddieclayton , please have a look

@maddieclayton
Copy link
Contributor

maddieclayton commented Dec 27, 2017

@chhabaramesh please add the changelog change to this PR and close the other issue - it is better to keep the two changes together so we don't release one without the other. After that I will reassign to Mark.

@markcowl markcowl removed their assignment Dec 28, 2017
@markcowl
Copy link
Member

@markcowl markcowl merged commit 0ddb46f into Azure:preview Dec 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants