Add KeyVault Token Capability for AccessToken auth #5158

markcowl · 2017-12-18T07:43:43Z

Description

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

I have read the contribution guidelines.
If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

Pull request includes test coverage for the included changes.
PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

maddieclayton · 2017-12-18T17:39:49Z

src/Common/Commands.Common.Authentication.Test/Commands.Common.Authentication.Test.csproj

@@ -1,5 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+  <Import Project="..\..\packages\xunit.runner.visualstudio.2.3.1\build\net20\xunit.runner.visualstudio.props" Condition="Exists('..\..\packages\xunit.runner.visualstudio.2.3.1\build\net20\xunit.runner.visualstudio.props')" />


Do you need both of these xunit runner packages?

maddieclayton · 2017-12-18T17:40:55Z

src/Common/Commands.Common.Authentication.Test/Commands.Common.Authentication.Test.csproj

@@ -16,7 +17,8 @@
    <TargetFrameworkProfile />
    <SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\..\</SolutionDir>
    <RestorePackages>true</RestorePackages>
-    <NuGetPackageImportStamp>9fdcb6f4</NuGetPackageImportStamp>


Is there a reason you are deleting this? If so, you likely should just remove the surrounding tags.

maddieclayton · 2017-12-18T17:41:55Z

src/Common/Commands.Common.Authentication.Test/Commands.Common.Authentication.Test.csproj

@@ -190,4 +192,10 @@
  </ItemGroup>
  <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
  <Import Project="..\..\packages\Microsoft.Bcl.Build.1.0.14\tools\Microsoft.Bcl.Build.targets" Condition="Exists('..\..\packages\Microsoft.Bcl.Build.1.0.14\tools\Microsoft.Bcl.Build.targets')" />
+  <Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">


Also not sure if this is necessary.

maddieclayton · 2017-12-18T17:46:39Z

src/Common/Commands.ScenarioTests.Common/Commands.ScenarioTests.Common.csproj

@@ -15,7 +15,8 @@
    <FileAlignment>512</FileAlignment>
    <SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\..\</SolutionDir>
    <RestorePackages>true</RestorePackages>
-    <NuGetPackageImportStamp>64a73b29</NuGetPackageImportStamp>


Same comments on this file as the first.

maddieclayton · 2017-12-18T17:47:17Z

...ds.ScenarioTests.ResourceManager.Common/Commands.ScenarioTests.ResourceManager.Common.csproj

@@ -15,7 +15,8 @@
    <FileAlignment>512</FileAlignment>
    <SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\..\</SolutionDir>
    <RestorePackages>true</RestorePackages>
-    <NuGetPackageImportStamp>e5bda5ba</NuGetPackageImportStamp>


markcowl · 2017-12-20T04:03:02Z

signing run here: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/powershell-sign/70/

on demand run here: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/powershell-demand/302/

maddieclayton · 2017-12-20T06:38:31Z

@azuresdkci Test this please

maddieclayton

One small comment, and then LGTM

maddieclayton · 2017-12-21T19:42:37Z

src/ResourceManager/KeyVault/Commands.KeyVault/Models/DataServiceCredential.cs

+            {
+                tenantId = context.Tenant.Id.ToString();
+            }
+            else if (string.IsNullOrWhiteSpace(tenantId) && context.Subscription != null && context.Account != null)


I don't think you need to check if the tenantId is empty - you just set it to empty above

markcowl · 2017-12-21T19:56:32Z

on demand run here: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/powershell-demand/303/
signing run here: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/powershell-sign/73/
holding on merge until we have an end-to-end test

markcowl · 2017-12-22T00:51:54Z

@azuresdkci test this please

markcowl · 2017-12-22T00:55:16Z

@azuresdkci retest this please

azuresdkci added the needs-review label Dec 18, 2017

maddieclayton reviewed Dec 18, 2017

View reviewed changes

markcowl added needs-revision and removed needs-review labels Dec 18, 2017

maddieclayton assigned markcowl Dec 18, 2017

markcowl added needs-review and removed needs-revision labels Dec 20, 2017

Add support for KeyVault Access Token

c624199

markcowl force-pushed the kvtoken branch from c3f4d7c to c624199 Compare December 21, 2017 07:05

maddieclayton approved these changes Dec 21, 2017

View reviewed changes

markcowl added Do Not Merge 🚫 and removed needs-review labels Dec 21, 2017

markcowl removed the Do Not Merge 🚫 label Dec 22, 2017

markcowl mentioned this pull request Dec 28, 2017

Removing exceptions thrown for AccessToken authentication #5135

Closed

13 tasks

markcowl merged commit 59aa7a2 into Azure:preview Dec 29, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add KeyVault Token Capability for AccessToken auth #5158

Add KeyVault Token Capability for AccessToken auth #5158

Uh oh!

markcowl commented Dec 18, 2017 •

edited

Loading

Uh oh!

maddieclayton Dec 18, 2017

Uh oh!

maddieclayton Dec 18, 2017

Uh oh!

maddieclayton Dec 18, 2017

Uh oh!

maddieclayton Dec 18, 2017

Uh oh!

maddieclayton Dec 18, 2017

Uh oh!

markcowl commented Dec 20, 2017

Uh oh!

maddieclayton commented Dec 20, 2017

Uh oh!

maddieclayton left a comment

Uh oh!

maddieclayton Dec 21, 2017

Uh oh!

markcowl commented Dec 21, 2017

Uh oh!

markcowl commented Dec 22, 2017

Uh oh!

markcowl commented Dec 22, 2017

Uh oh!

Uh oh!

Add KeyVault Token Capability for AccessToken auth #5158

Add KeyVault Token Capability for AccessToken auth #5158

Uh oh!

Conversation

markcowl commented Dec 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markcowl commented Dec 20, 2017

Uh oh!

maddieclayton commented Dec 20, 2017

Uh oh!

maddieclayton left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markcowl commented Dec 21, 2017

Uh oh!

markcowl commented Dec 22, 2017

Uh oh!

markcowl commented Dec 22, 2017

Uh oh!

Uh oh!

markcowl commented Dec 18, 2017 •

edited

Loading