Skip to content

Update CheckSignature Authenticode check to exclude NLog dependency #5164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 20, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions src/ResourceManager/DataLakeStore/AzureRM.DataLakeStore.psd1
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# RootModule = ''

# Version number of this module.
ModuleVersion = '5.0.0'
ModuleVersion = '5.0.1'

# Supported PSEditions
# CompatiblePSEditions = @()
Expand Down Expand Up @@ -54,7 +54,7 @@ CLRVersion = '4.0'
RequiredModules = @(@{ModuleName = 'AzureRM.Profile'; ModuleVersion = '4.1.1'; })

# Assemblies that must be loaded prior to importing this module
RequiredAssemblies = '.\Microsoft.Azure.Management.DataLake.Store.dll'
RequiredAssemblies = '.\Microsoft.Azure.Management.DataLake.Store.dll','.\Microsoft.Azure.DataLake.Store.dll','.\NLog.dll'

# Script files (.ps1) that are run in the caller's environment prior to importing this module.
# ScriptsToProcess = @()
Expand All @@ -63,8 +63,7 @@ RequiredAssemblies = '.\Microsoft.Azure.Management.DataLake.Store.dll'
# TypesToProcess = @()

# Format files (.ps1xml) to be loaded when importing this module
FormatsToProcess =
'.\Microsoft.Azure.Commands.DataLakeStoreFileSystem.format.ps1xml'
FormatsToProcess = '.\Microsoft.Azure.Commands.DataLakeStoreFileSystem.format.ps1xml'

# Modules to import as nested modules of the module specified in RootModule/ModuleToProcess
NestedModules = @('.\Microsoft.Azure.Commands.DataLakeStore.dll')
Expand Down Expand Up @@ -152,14 +151,16 @@ PrivateData = @{
# IconUri = ''

# ReleaseNotes of this module
ReleaseNotes = '* NOTE: This is a breaking change release. Please see the migration guide (https://aka.ms/azps-migration-guide) for a full list of breaking changes introduced.
* Removed the Obsolete Properties fields in PSDataLakeStoreAccount.cs and its assoicated files
* Changed one of the two OutputTypes of Get-AzureRmDataLakeStoreAccount
- List\<PSDataLakeStoreAccount> to List\<PSDataLakeStoreAccountBasic>
- The properties of PSDataLakeStoreAccountBasic is a strict subset of the properties of PSDataLakeStoreAccount
- The additional properties that are in PSDataLakeStoreAccount are not returned by the service. Therefore, this change is to reflect this accurately. These additional properties are still in PSDataLakeStoreAccountBasic, but they are tagged as Obsolete.
* Add support for online help
- Run Get-Help with the -Online parameter to open the online help in your default Internet browser'
ReleaseNotes = '
* Export-AzureRmDataLakeStoreItem (https://github.com/Azure/azure-powershell/blob/adls-data-plane/src/ResourceManager/DataLakeStore/documentation/upcoming-breaking-changes.md) - Deprecated parameters PerFileThreadCount, ConcurrentFileCount and introduced parameter Concurrency
* Import-AzureRMDataLakeStoreItem (https://github.com/Azure/azure-powershell/blob/adls-data-plane/src/ResourceManager/DataLakeStore/documentation/upcoming-breaking-changes.md) -Deprecated parametersPerFileThreadCount, ConcurrentFileCount and introduced parameter Concurrency
* Get-AzureRMDataLakeStoreItemContent - Fixed the tail behavior for contents greater than 4MB
* Set-AzureRMDataLakeStoreItemExpiry - Introduced new parameter set SetRelativeExpiry for setting relative expiration time
* Remove-AzureRmDataLakeStoreItem (https://github.com/Azure/azure-powershell/blob/adls-data-plane/src/ResourceManager/DataLakeStore/documentation/upcoming-breaking-changes.md) - Deprecated parameter Clean.
'

# Prerelease string of this module
Prerelease = 'preview'

# External dependent modules of this module
# ExternalModuleDependencies = ''
Expand Down
38 changes: 4 additions & 34 deletions src/ResourceManager/DataLakeStore/ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,41 +19,11 @@
-->
## Current Release

* Moved from AutoRest sdk to our version of Dataplane sdk for Azure data lake.
* Refactored following cmdlets to use the new version of SDK:
* Add-AzureRmDataLakeStoreItemContent
* Export-AzureRmDataLakeStoreItem
* Get-AzureRmDataLakeStoreChildItem
* Get-AzureRmDataLakeStoreItem
* Get-AzureRmDataLakeStoreItemAclEntry
* Get-AzureRmDataLakeStoreItemContent
* Get-AzureRmDataLakeStoreItemOwner
* Get-AzureRmDataLakeStoreItemPermission
* Import-AzureRmDataLakeStoreItem
* Join-AzureRmDataLakeStoreItem
* Move-AzureRmDataLakeStoreItem
* New-AzureRmDataLakeStoreItem
* Remove-AzureRmDataLakeStoreItem
* Remove-AzureRmDataLakeStoreItemAcl
* Remove-AzureRmDataLakeStoreItemAclEntry
* Set-AzureRmDataLakeStoreItemAcl
* Set-AzureRmDataLakeStoreItemAclEntry
* Set-AzureRmDataLakeStoreItemExpiry
* Set-AzureRmDataLakeStoreItemOwner
* Set-AzureRmDataLakeStoreItemPermission
* Test-AzureRmDataLakeStoreItem
* Refactored following models to use models from new SDK:
* DataLakeStoreEnums
* DataLakeStoreFileSystemClient
* DataLakeStoreItem
* DataLakeStoreItemAce
* DataLakeStorePathInstance
* Moved the commands and models related to the dataplane into separate folders
* Export-AzureRmDataLakeStoreItem (documented in the breaking changes) - Deprecated parameters PerFileThreadCount, ConcurrentFileCount and introduced parameter Concurrency
* Import-AzureRMDataLakeStoreItem (documented in the breaking changes) -Deprecated parametersPerFileThreadCount, ConcurrentFileCount and introduced parameter Concurrency
* Export-AzureRmDataLakeStoreItem (https://github.com/Azure/azure-powershell/blob/adls-data-plane/src/ResourceManager/DataLakeStore/documentation/upcoming-breaking-changes.md) - Deprecated parameters PerFileThreadCount, ConcurrentFileCount and introduced parameter Concurrency
* Import-AzureRMDataLakeStoreItem (https://github.com/Azure/azure-powershell/blob/adls-data-plane/src/ResourceManager/DataLakeStore/documentation/upcoming-breaking-changes.md) -Deprecated parametersPerFileThreadCount, ConcurrentFileCount and introduced parameter Concurrency
* Get-AzureRMDataLakeStoreItemContent - Fixed the tail behavior for contents greater than 4MB
* Set-AzureRMDataLakeStoreItemExpiry - Introduced new parameter set for setting relative expiration time
* Remove-AzureRmDataLakeStoreItem (documented in the breaking changes) - Deprecated parameter Clean.
* Set-AzureRMDataLakeStoreItemExpiry - Introduced new parameter set SetRelativeExpiry for setting relative expiration time
* Remove-AzureRmDataLakeStoreItem (https://github.com/Azure/azure-powershell/blob/adls-data-plane/src/ResourceManager/DataLakeStore/documentation/upcoming-breaking-changes.md) - Deprecated parameter Clean.

## Version 5.0.0
* NOTE: This is a breaking change release. Please see the migration guide (https://aka.ms/azps-migration-guide) for a full list of breaking changes introduced.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,5 @@
// by using the '*' as shown below:


[assembly: AssemblyVersion("5.0.0")]
[assembly: AssemblyFileVersion("5.0.0")]
[assembly: AssemblyVersion("5.0.1")]
[assembly: AssemblyFileVersion("5.0.1")]
3 changes: 2 additions & 1 deletion tools/CheckSignature.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ function Check-All {
$files = $files | Where-Object { ($_.FullName -notlike "*Newtonsoft.Json*") -and `
($_.FullName -notlike "*AutoMapper*") -and `
($_.FullName -notlike "*Security.Cryptography*") -and `
($_.FullName -notlike "*NLog*") -and `
($_.FullName -notlike "*BouncyCastle.Crypto*")}
Write-Host "Checking the authenticode signature of $($files.Count) files (.dll, .ps1, .psm1)" -ForegroundColor Yellow

Expand Down Expand Up @@ -209,4 +210,4 @@ else
Write-Host "No switch parameter set - checking all files in current directory" -ForegroundColor Yellow
}

Check-All $path
Check-All $path