Skip to content

Remove extra validation of the sku names on create new capacity #5165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2017

Conversation

selasagi
Copy link
Contributor

@selasagi selasagi commented Dec 20, 2017

Description


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • [ X] Title of the pull request is clear and informative.
  • [ X] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • [X ] Pull request includes test coverage for the included changes.
  • [X ] PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • [X ] New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • [X ] Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • [X ] Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • [X ] Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • [ X] Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

@maddieclayton
Copy link
Contributor

@selasagi Is this change happening because the ValidateSet represents values that will always be in the list of available skus? I just want to make sure I fully understand this change.

@selasagi
Copy link
Contributor Author

Yes, the ValidateSet represents values that will always be in the list of available skus but we have now bug which that the available skus API returns empty list for some subscriptions. I mean that for now part of our users can't use that cmdlet for every sku value.
That is the reason this fix is so important!

@selasagi
Copy link
Contributor Author

We fix the bug in the available skus API but it is not in production yet (and it will take more time because of the holidays..)

@maddieclayton
Copy link
Contributor

@maddieclayton maddieclayton removed their assignment Dec 21, 2017
@maddieclayton
Copy link
Contributor

@azuresdkci Test this please

@maddieclayton maddieclayton merged commit e18fd1c into Azure:preview Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants