Skip to content

Merge master into preview after Storage gallery release #5190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Dec 29, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
cac4a86
Upgrade to SRP SDK 7.0 with migrate NetworkRule API change
blueww Nov 17, 2017
c9e7e7e
Support StorageV2 Account Kind
blueww Nov 17, 2017
cf612e9
remove unnecessary reference of AzureRM.Storage
blueww Nov 22, 2017
b75a0a2
Fix the OutputType of of new/Set-AzureRMstorageAccount
blueww Nov 22, 2017
c441083
Add changelog for storagev2
blueww Nov 23, 2017
6e77f89
Merge pull request #5012 from wastoresh/storage-v2
cormacpayne Nov 27, 2017
54237bd
Support Set-AzureRMstorageAccount with Kind StorageV2
blueww Dec 8, 2017
e5ddff7
Merge branch 'AzureRm.Storage.V2' into storage-v2
markcowl Dec 12, 2017
4cee3a7
Update Commands.Storage.Netcore.csproj
markcowl Dec 12, 2017
ebf8f3b
Change the -Kind in Set-AzureRMstorageAccount to -UpgradeToStorageV2
blueww Dec 12, 2017
11d15be
Merge pull request #5133 from Azure/storage-v2
markcowl Dec 12, 2017
41ce64e
[AzureRM.Storage] Upgrade version and ReleaseNotes
blueww Dec 12, 2017
cc1aa02
Fix a Unit Test issue
blueww Dec 12, 2017
218890d
Merge branch 'AzureRm.Storage.V2' into storage-v2
markcowl Dec 12, 2017
c516bf1
Merge pull request #5110 from wastoresh/storage-v2
markcowl Dec 13, 2017
dec9de0
Update AzureRM to include new storage management version
markcowl Dec 13, 2017
a903968
[AzureRM.Storage]remove the private package for SRP SDK 7.1.0
blueww Dec 13, 2017
069a758
Merge pull request #5137 from wastoresh/storage-v2
markcowl Dec 16, 2017
c001d1b
Merge pull request #5178 from Azure/AzureRm.Storage.V2
Dec 27, 2017
1ffb0da
Merge branch 'preview' into master
Dec 27, 2017
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/ResourceManager/Storage/AzureRM.Storage.psd1
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# RootModule = ''

# Version number of this module.
ModuleVersion = '4.0.1'
ModuleVersion = '4.1.0'

# Supported PSEditions
# CompatiblePSEditions = @()
Expand Down Expand Up @@ -122,7 +122,10 @@ PrivateData = @{
# IconUri = ''

# ReleaseNotes of this module
ReleaseNotes = '* Fixed assembly loading issue that caused some cmdlets to fail when executing'
ReleaseNotes = '* Upgrade SRP SDK to 7.1.0
* Add StorageV2 account kind to resource mode storage account cmdlets
- New-AzureRmStorageAccount
- Set-AzureRmStorageAccount'

# External dependent modules of this module
# ExternalModuleDependencies = ''
Expand Down
5 changes: 4 additions & 1 deletion src/ResourceManager/Storage/ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,12 @@
- Additional information about change #1
-->
## Current Release
* Upgrade SRP SDK to 7.1.0
* Add StorageV2 account kind to resource mode storage account cmdlets
- New-AzureRmStorageAccount
- Set-AzureRmStorageAccount
* Added Location Completer to -Location parameters allowing tab completion through valid Locations
* Added ResourceGroup Completer to -ResourceGroup parameters allowing tab completion through resource groups in current subscription

## Version 4.0.1
* Fixed assembly loading issue that caused some cmdlets to fail when executing

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@
<Reference Include="Microsoft.Azure.Management.Authorization">
<HintPath>..\..\..\packages\Microsoft.Azure.Management.Authorization.2.0.0\lib\net40\Microsoft.Azure.Management.Authorization.dll</HintPath>
</Reference>
<Reference Include="Microsoft.Azure.Management.Storage, Version=6.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Microsoft.Azure.Management.Storage.6.5.0-preview\lib\net452\Microsoft.Azure.Management.Storage.dll</HintPath>
<Reference Include="Microsoft.Azure.Management.Storage, Version=7.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Microsoft.Azure.Management.Storage.7.1.0-preview\lib\net452\Microsoft.Azure.Management.Storage.dll</HintPath>
</Reference>
<Reference Include="Microsoft.Azure.ResourceManager, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion>
Expand All @@ -72,10 +72,10 @@
<HintPath>..\..\..\packages\Microsoft.IdentityModel.Clients.ActiveDirectory.2.28.3\lib\net45\Microsoft.IdentityModel.Clients.ActiveDirectory.WindowsForms.dll</HintPath>
</Reference>
<Reference Include="Microsoft.Rest.ClientRuntime, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Microsoft.Rest.ClientRuntime.2.3.8\lib\net452\Microsoft.Rest.ClientRuntime.dll</HintPath>
<HintPath>..\..\..\packages\Microsoft.Rest.ClientRuntime.2.3.10\lib\net452\Microsoft.Rest.ClientRuntime.dll</HintPath>
</Reference>
<Reference Include="Microsoft.Rest.ClientRuntime.Azure, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Microsoft.Rest.ClientRuntime.Azure.3.3.7\lib\net452\Microsoft.Rest.ClientRuntime.Azure.dll</HintPath>
<HintPath>..\..\..\packages\Microsoft.Rest.ClientRuntime.Azure.3.3.10\lib\net452\Microsoft.Rest.ClientRuntime.Azure.dll</HintPath>
</Reference>
<Reference Include="Microsoft.Rest.ClientRuntime.Azure.Authentication, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Microsoft.Rest.ClientRuntime.Azure.Authentication.2.2.9-preview\lib\net45\Microsoft.Rest.ClientRuntime.Azure.Authentication.dll</HintPath>
Expand Down Expand Up @@ -200,6 +200,9 @@
<None Include="SessionRecords\Microsoft.Azure.Commands.Management.Storage.Test.ScenarioTests.StorageAccountTests\TestStorageAccount.json">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
<None Include="SessionRecords\Microsoft.Azure.Commands.Management.Storage.Test.ScenarioTests.StorageAccountTests\TestSetAzureStorageAccountStorageV2.json">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
</ItemGroup>
<ItemGroup>
<Service Include="{82A7F48D-3B50-4B1E-B82E-3ADA8210C358}" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -168,4 +168,14 @@ Gets the Canary location for a provider
function Get-ProviderLocation_Canary($provider)
{
"eastus2euap"
}


<#
.SYNOPSIS
Gets the Stage location for a provider
#>
function Get-ProviderLocation_Stage($provider)
{
"eastus2(stage)"
}
Original file line number Diff line number Diff line change
Expand Up @@ -112,5 +112,11 @@ public void TestNetworkRule()
TestController.NewInstance.RunPsTest("Test-NetworkRule");
}

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
public void TestSetAzureStorageAccountStorageV2()
{
TestController.NewInstance.RunPsTest("Test-SetAzureStorageAccountStorageV2");
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -129,12 +129,21 @@ function Test-NewAzureStorageAccount
{
# Test
$stoname = 'sto' + $rgname;
$stotype = 'Standard_GRS';
$loc = Get-ProviderLocation ResourceManagement;
$stotype = 'Standard_ZRS';
$kind = 'StorageV2'

$loc = Get-ProviderLocation ResourceManagement;
New-AzureRmResourceGroup -Name $rgname -Location $loc;

New-AzureRmStorageAccount -ResourceGroupName $rgname -Name $stoname -Location $loc -Type $stotype;
$loc = Get-ProviderLocation_Stage ResourceManagement;
New-AzureRmStorageAccount -ResourceGroupName $rgname -Name $stoname -Location $loc -Type $stotype -Kind $kind;

$sto = Get-AzureRmStorageAccount -ResourceGroupName $rgname -Name $stoname;
$stotype = 'StandardZRS';
Assert-AreEqual $sto.StorageAccountName $stoname;
Assert-AreEqual $sto.Sku.Name $stotype;
Assert-AreEqual $sto.Location $loc;
Assert-AreEqual $sto.Kind $kind;

Retry-IfException { Remove-AzureRmStorageAccount -Force -ResourceGroupName $rgname -Name $stoname; }
}
Expand Down Expand Up @@ -511,7 +520,6 @@ function Test-SetAzureRmCurrentStorageAccount
}
}


<#
.SYNOPSIS
Test NetworkRule
Expand Down Expand Up @@ -602,3 +610,50 @@ function Test-NetworkRule
Clean-ResourceGroup $rgname
}
}

<#
.SYNOPSIS
Test SetAzureStorageAccount with Kind as StorageV2
.Description
AzureAutomationTest
#>
function Test-SetAzureStorageAccountStorageV2
{
# Setup
$rgname = Get-StorageManagementTestResourceName;

try
{
# Test
$stoname = 'sto' + $rgname;
$stotype = 'Standard_GRS';
$loc = Get-ProviderLocation ResourceManagement;
$kind = 'Storage'

New-AzureRmResourceGroup -Name $rgname -Location $loc;
$loc = Get-ProviderLocation_Stage ResourceManagement;
New-AzureRmStorageAccount -ResourceGroupName $rgname -Name $stoname -Location $loc -Type $stotype -Kind $kind;

Retry-IfException { $global:sto = Get-AzureRmStorageAccount -ResourceGroupName $rgname -Name $stoname; }
$stotype = 'StandardGRS';
Assert-AreEqual $sto.StorageAccountName $stoname;
Assert-AreEqual $sto.Sku.Name $stotype;
Assert-AreEqual $sto.Location $loc;
Assert-AreEqual $sto.Kind $kind;

$kind = 'StorageV2'
Set-AzureRmStorageAccount -ResourceGroupName $rgname -Name $stoname -UpgradeToStorageV2;
$sto = Get-AzureRmStorageAccount -ResourceGroupName $rgname -Name $stoname;
Assert-AreEqual $sto.StorageAccountName $stoname;
Assert-AreEqual $sto.Sku.Name $stotype;
Assert-AreEqual $sto.Location $loc;
Assert-AreEqual $sto.Kind $kind;

Remove-AzureRmStorageAccount -Force -ResourceGroupName $rgname -Name $stoname;
}
finally
{
# Cleanup
Clean-ResourceGroup $rgname
}
}
Loading