Skip to content

Update websites-preview branch #5308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 150 commits into from
Jan 19, 2018
Merged

Update websites-preview branch #5308

merged 150 commits into from
Jan 19, 2018

Conversation

markcowl
Copy link
Member

Description


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

anusapan and others added 30 commits November 21, 2017 18:27
Certificate support for IotHub cmdlets
Update auditing help messages
Update Auditing parameter descriptions
Update changelog.
1. Apply Cognitive Services SDK 3.0.0.0
2. Update NuGet refs
Downgrade Newtonsoft.Json 10->6 as 10 resutls in UT cases fail at buddy
build (though can pass at my local).
Downgrade NuGet refs in Test project as UT cases in buddy build keep
failing.
Add breaking changes into exception list.
anusapan and others added 25 commits January 16, 2018 17:02
Add -AsJob parameter to long running Resource cmdlets
…-Dec

Update Cognitive Services Mgmt. PS with the latest Cognitive Services Mgmt. SDK
Fixes:5181: Set-AzureRmAppServicePlan errors out for a Premium V2 App
Updated AAD Authority for AzureUSGovernment
Fix broken links per issue 472
[Azure.Storage] Fix a null reference issue in New-AzureRMStorageAccount
Add missing output to New-AzureRmWebApp
Certificate support for IotHub cmdlets
Obsolete all -Tags parameters and add alias to -Tag
Removed the -ExpandPrincipalGroups parameter for Example 2, since it is an invalid parameter for that parameter set. For more details, see #5193
Embed PowerShell in Cloud Shell link in ReadMe
@markcowl markcowl merged commit 7113b48 into websites-preview Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.