OSA Restore in RecoveryServices.Backup #5310

dragonfly91 · 2018-01-19T11:16:06Z

Adding UseOriginalStorageAccountForDiskRestore parameter to Restore cmdlet.

Description

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

I have read the contribution guidelines.
If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

Pull request includes test coverage for the included changes.
PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

maddieclayton · 2018-01-19T17:37:16Z

@dragonfly91 The parameter name is currently very long, I think that -UseOriginalStorageAccount would work as well without losing clarity for the user. Also, can you update the changelog with this change?

maddieclayton · 2018-01-20T01:36:04Z

...veryServices.Backup/Commands.RecoveryServices.Backup.Test/ScenarioTests/IaasVm/ItemTests.ps1

@@ -213,6 +213,13 @@ function Test-AzureVMFullRestore

 		Set-AzureRmRecoveryServicesVaultContext -Vault $vault;

+		Assert-ThrowsContains { Restore-AzureRmRecoveryServicesBackupItem `


Can you add a positive test for this parameter?

This feature is not enabled by default, so setting up the test artefacts for the positive case is quite difficult. Will take this up at a later time when the feature is enabled by default.

maddieclayton · 2018-01-20T01:36:27Z

...Commands.RecoveryServices.Backup/Cmdlets/Restore/RestoreAzureRMRecoveryServicesBackupItem.cs

+        /// <summary>
+        /// Use this switch if the disks from the recovery point are to be restored to their original storage accounts
+        /// </summary>
+        [Parameter(Mandatory = false, Position = 3,


No position is necessary for SwitchParameters

…mdlet.

…rameter in the Restore cmdlet.

markcowl

@dragonfly91 It is OK to defer the test as long as you file a test debt issue for this, assign it to yourself, and put it into the next milestone (2018-02-09). Meanwhile, please fix the mismatch between help and cmdlet

markcowl · 2018-01-22T16:42:43Z

...es.Backup/Commands.RecoveryServices.Backup/help/Restore-AzureRmRecoveryServicesBackupItem.md

@@ -15,8 +15,8 @@ Restores the data and configuration for a Backup item to a recovery point.

 ```
 Restore-AzureRmRecoveryServicesBackupItem [-RecoveryPoint] <RecoveryPointBase> [-StorageAccountName] <String>
- [-StorageAccountResourceGroupName] <String> [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm]
- [<CommonParameters>]
+ [-StorageAccountResourceGroupName] <String> [-UseOriginalStorageAccountForDiskRestore]


The parameter name in help does not match the test parameter. This needs to be corrected before we can release

cormacpayne · 2018-01-22T17:46:20Z

On-demand: https://azuresdkci.westus2.cloudapp.azure.com/job/powershell-demand/376/

dragonfly91 · 2018-01-22T18:21:08Z

Hi @markcowl, filed the following issue for the positive test case: #5331

… in Restore cmdlet

dragonfly91 · 2018-01-22T18:50:39Z

Hi, I've addressed all the comments. Is it possible for this PR to be part of the current Jan release?

Approved offline

azuresdkci added the needs-review label Jan 19, 2018

azuresdkci assigned maddieclayton Jan 19, 2018

maddieclayton assigned dragonfly91 and unassigned maddieclayton Jan 19, 2018

maddieclayton added needs-revision and removed needs-review labels Jan 19, 2018

dragonfly91 force-pushed the osarestore branch from af63208 to 453cd25 Compare January 19, 2018 22:49

maddieclayton previously requested changes Jan 20, 2018

View reviewed changes

Samuel Anudeep added 3 commits January 22, 2018 15:59

Adding UseOriginalStorageAccountForDiskRestore parameter to Restore c…

45a4673

…mdlet.

[RecoveryServices.Backup] Updating param name and changelog.

9b775d2

[RS.Backup] Removed Position from UseOriginalStorageAccount switch pa…

f7b188d

…rameter in the Restore cmdlet.

dragonfly91 force-pushed the osarestore branch from 453cd25 to f7b188d Compare January 22, 2018 10:30

markcowl previously requested changes Jan 22, 2018

View reviewed changes

markcowl assigned cormacpayne Jan 22, 2018

cormacpayne added Waiting for On Demand and removed needs-revision labels Jan 22, 2018

cormacpayne unassigned dragonfly91 and cormacpayne Jan 22, 2018

[RS.Backup] Update help text for -UseOriginalStorageAccount parameter…

205cea9

… in Restore cmdlet

dragonfly91 force-pushed the osarestore branch from 58d3d57 to 205cea9 Compare January 22, 2018 18:31

cormacpayne approved these changes Jan 22, 2018

View reviewed changes

cormacpayne merged commit 8cfd729 into Azure:preview Jan 22, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

OSA Restore in RecoveryServices.Backup #5310

OSA Restore in RecoveryServices.Backup #5310

Uh oh!

dragonfly91 commented Jan 19, 2018 •

edited

Loading

Uh oh!

maddieclayton commented Jan 19, 2018

Uh oh!

maddieclayton Jan 20, 2018

Uh oh!

dragonfly91 Jan 22, 2018

Uh oh!

maddieclayton Jan 20, 2018

Uh oh!

markcowl left a comment

Uh oh!

markcowl Jan 22, 2018

Uh oh!

cormacpayne commented Jan 22, 2018

Uh oh!

dragonfly91 commented Jan 22, 2018 •

edited

Loading

Uh oh!

dragonfly91 commented Jan 22, 2018 •

edited

Loading

Uh oh!

Uh oh!

		@@ -213,6 +213,13 @@ function Test-AzureVMFullRestore

		Set-AzureRmRecoveryServicesVaultContext -Vault $vault;

		Assert-ThrowsContains { Restore-AzureRmRecoveryServicesBackupItem `

OSA Restore in RecoveryServices.Backup #5310

OSA Restore in RecoveryServices.Backup #5310

Uh oh!

Conversation

dragonfly91 commented Jan 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

maddieclayton commented Jan 19, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markcowl left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cormacpayne commented Jan 22, 2018

Uh oh!

dragonfly91 commented Jan 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dragonfly91 commented Jan 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

dragonfly91 commented Jan 19, 2018 •

edited

Loading

dragonfly91 commented Jan 22, 2018 •

edited

Loading

dragonfly91 commented Jan 22, 2018 •

edited

Loading