Skip to content

Simplified Parameter set for VM ScaleSet Creation #5315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jan 20, 2018

Conversation

markcowl
Copy link
Member

@markcowl markcowl commented Jan 19, 2018

Replaces #5093

Description


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

Hovsep Mkrtchyan and others added 22 commits December 7, 2017 22:30
…nto release-5.1.0

# Conflicts:
#	src/ResourceManager/Compute/Commands.Compute/Strategies/Network/SubnetStrategy.cs
…nto release-5.1.0

# Conflicts:
#	src/ResourceManager/Compute/ChangeLog.md
…rshell into release-5.1.0

# Conflicts:
#	src/ResourceManager/Compute/ChangeLog.md
@markcowl markcowl mentioned this pull request Jan 19, 2018
13 tasks
@markcowl
Copy link
Member Author

Copy link
Contributor

@maddieclayton maddieclayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are comments only on the markdown. I assume the cmdlet hasn't been changed.

Accept wildcard characters: False
```

### -Zone
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yaml

```

### -Location
The Azure location where this Scale Set will be created. A default location will be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all of these, can you mention the default value or how it is determined?

```
New-AzureRmVmss [-ResourceGroupName] <String> [-VMScaleSetName] <String>
[-VirtualMachineScaleSet] <PSVirtualMachineScaleSet> [-AsJob] [-DefaultProfile <IAzureContextContainer>]
[-WhatIf] [-Confirm] [<CommonParameters>]
```

### SimpleParameterSet
```
New-AzureRmVmss [-AsJob] [[-ResourceGroupName] <String>] [-VMScaleSetName] <String> [-ImageName <String>]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how the -AsJob ended up first in the order if it's last on the list of parameters.... can you regenerate one more time and see if it moves to the end?

@maddieclayton
Copy link
Contributor

@markcowl markcowl merged commit 5821259 into Azure:preview Jan 20, 2018
@markcowl markcowl deleted the vmsssimple branch January 20, 2018 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants