-
Notifications
You must be signed in to change notification settings - Fork 4k
Simplified Parameter set for VM ScaleSet Creation #5315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Improved NestedResource configuration
…nto release-5.1.0 # Conflicts: # src/ResourceManager/Compute/Commands.Compute/Strategies/Network/SubnetStrategy.cs
…nto release-5.1.0 # Conflicts: # src/ResourceManager/Compute/ChangeLog.md
…rshell into release-5.1.0 # Conflicts: # src/ResourceManager/Compute/ChangeLog.md
…nto release-5.1.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are comments only on the markdown. I assume the cmdlet hasn't been changed.
Accept wildcard characters: False | ||
``` | ||
|
||
### -Zone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yaml
``` | ||
|
||
### -Location | ||
The Azure location where this Scale Set will be created. A default location will be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all of these, can you mention the default value or how it is determined?
``` | ||
New-AzureRmVmss [-ResourceGroupName] <String> [-VMScaleSetName] <String> | ||
[-VirtualMachineScaleSet] <PSVirtualMachineScaleSet> [-AsJob] [-DefaultProfile <IAzureContextContainer>] | ||
[-WhatIf] [-Confirm] [<CommonParameters>] | ||
``` | ||
|
||
### SimpleParameterSet | ||
``` | ||
New-AzureRmVmss [-AsJob] [[-ResourceGroupName] <String>] [-VMScaleSetName] <String> [-ImageName <String>] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how the -AsJob ended up first in the order if it's last on the list of parameters.... can you regenerate one more time and see if it moves to the end?
… fix syntax parameter order
Replaces #5093
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines