EventGrid: Updated to use the latest version of the .NET SDK #5367

kalyanaj · 2018-01-25T20:15:10Z

Description

EventGrid: Updated to use the latest version of the .NET SDK and re-recorded the tests.

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

I have read the contribution guidelines.
If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

Pull request includes test coverage for the included changes.
PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

…SDK.

cormacpayne · 2018-01-25T21:13:26Z

@kalyanaj you can revert the version changes that you are making - we will update the versions for you during the release, or if you would like to release this module out-of-band, then we will use our (under construction) versioning tool to determine the proper version bump for the module.

cormacpayne

@kalyanaj two comments, otherwise this LGTM

cormacpayne · 2018-01-30T17:00:17Z

src/ResourceManager/EventGrid/Commands.EventGrid.Test/ScenarioTests/EventSubscriptionTests.ps1

+
+    # Write-Debug "Updating eventSubscription $eventSubscriptionName to resource group $resourceGroupName"
+    # $newLabels = "Marketing", "Sales"
+    # $updateResult = Update-AzureRmEventGridSubscription -ResourceGroup $resourceGroupName -EventSubscriptionName $eventSubscriptionName -SubjectEndsWith "NewSuffix" -Label $newLabels


@kalyanaj does this mean this scenario is currently broken in the latest version of AzureRM.EventGrid, or that the new API version does not currently support this scenario?

It impacted all API versions. A service fix was deployed yesterday that resolves this issue - I have uncommented out these lines and am re-recording the tests to re-include this change.

cormacpayne · 2018-01-30T17:06:41Z

src/ResourceManager/EventGrid/Commands.EventGrid/Utilities/EventGridClient.cs

@@ -178,7 +178,7 @@ public TopicSharedAccessKeys RegenerateTopicKey(string resourceGroupName, string
                eventSubscription.Labels = new List<string>(labels);
            }

-            return this.Client.EventSubscriptions.Create(scope, eventSubscriptionName, eventSubscription);
+            return this.Client.EventSubscriptions.CreateOrUpdate(scope, eventSubscriptionName, eventSubscription);


@kalyanaj does this affect when users should decide between New-AzureRmEventGridSubscription vs Update-AzureRmEventGridSubscription?

No, it shouldn't. Update-AzureRmEventGridSubscription maps to a PATCH request and can be used to perform a partial update of the resource (e.g. in the case of event subscriptions, I want to update only the "filter" and not the "destination"). New-AzureRmEventGridSubscription maps to a PUT request which either creates or replaces the resource.

…nto preview # Conflicts: # src/ResourceManager/EventGrid/ChangeLog.md

…into preview # Conflicts: # src/ResourceManager/EventGrid/ChangeLog.md

…ding last time).

cormacpayne · 2018-01-31T17:10:55Z

On-demand: https://azuresdkci.westus2.cloudapp.azure.com/job/powershell-demand/394/

kalyanaj added 2 commits January 24, 2018 15:15

Updated to use the 1.2.0-preview version of the EventGrid Management …

bc7dee6

…SDK.

Re-recorded the tests.

f081465

kalyanaj requested a review from cormacpayne January 25, 2018 20:15

azuresdkci added the needs-review label Jan 25, 2018

azuresdkci assigned maddieclayton Jan 25, 2018

cormacpayne added needs-revision and removed needs-review labels Jan 25, 2018

cormacpayne assigned kalyanaj and unassigned maddieclayton Jan 25, 2018

Reverted the module version number updates.

03aa72f

maddieclayton added needs-review and removed needs-revision labels Jan 25, 2018

maddieclayton assigned cormacpayne and unassigned kalyanaj Jan 25, 2018

Merge branch 'preview' into preview

5584981

cormacpayne suggested changes Jan 30, 2018

View reviewed changes

cormacpayne added needs-revision and removed needs-review labels Jan 30, 2018

cormacpayne assigned kalyanaj and unassigned cormacpayne Jan 30, 2018

kalyanaj added 4 commits January 30, 2018 10:17

Re-recorded the tests to include the Update scenario.

2c24733

Merge branch 'preview' of https://github.com/azure/azure-powershell i…

6cfdc4f

…nto preview # Conflicts: # src/ResourceManager/EventGrid/ChangeLog.md

Fixed a merge issue in changelog.md.

209856d

Merge branch 'preview' of https://github.com/kalyanaj/azure-powershell …

6b92c2e

…into preview # Conflicts: # src/ResourceManager/EventGrid/ChangeLog.md

kalyanaj assigned cormacpayne and unassigned kalyanaj Jan 30, 2018

kalyanaj and others added 2 commits January 30, 2018 12:34

Re-recorded the tests (had missed binplacing the PS test before recor…

cde0c4e

…ding last time).

Merge branch 'preview' into preview

2c0c0c9

cormacpayne approved these changes Jan 31, 2018

View reviewed changes

cormacpayne added Waiting for On Demand and removed needs-revision labels Jan 31, 2018

cormacpayne removed their assignment Jan 31, 2018

cormacpayne merged commit dfdafe8 into Azure:preview Jan 31, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

EventGrid: Updated to use the latest version of the .NET SDK #5367

EventGrid: Updated to use the latest version of the .NET SDK #5367

Uh oh!

kalyanaj commented Jan 25, 2018 •

edited by azuresdkci

Loading

Uh oh!

cormacpayne commented Jan 25, 2018

Uh oh!

cormacpayne left a comment

Uh oh!

cormacpayne Jan 30, 2018

Uh oh!

kalyanaj Jan 30, 2018

Uh oh!

cormacpayne Jan 30, 2018

Uh oh!

kalyanaj Jan 30, 2018

Uh oh!

cormacpayne commented Jan 31, 2018

Uh oh!

Uh oh!

EventGrid: Updated to use the latest version of the .NET SDK #5367

EventGrid: Updated to use the latest version of the .NET SDK #5367

Uh oh!

Conversation

kalyanaj commented Jan 25, 2018 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

cormacpayne commented Jan 25, 2018

Uh oh!

cormacpayne left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cormacpayne commented Jan 31, 2018

Uh oh!

Uh oh!

kalyanaj commented Jan 25, 2018 •

edited by azuresdkci

Loading