-
Notifications
You must be signed in to change notification settings - Fork 4k
Typo in documentation for the "Port" parameter. #5375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In relation to this change where the "Ports" parameter was renamed to "Port": 026c016
Can one of the admins verify this patch? |
@azuresdkci Test this please |
@BrandonBoone Hey Brandon, thanks for this fix! I added another commit to your branch that updates a file that determines which tests get run based on the files changed in the PR. Apparently, it didn't include the |
@cormacpayne - Sure thing. My intent here was only to update the documentation since the code example for |
@azuresdkci test this please |
@azuresdkci test this please |
In relation to this change where the "Ports" parameter was renamed to "Port": 026c016
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines