Show OperationID from CloudException thrown by Compute Cmdlets #546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 0.9.4
Release 0.9.4
Release 0.9.4
Release 0.9.4
|
Hi @huangpf, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
huangpf
changed the title
Fix Start/Stop/Update-AzureVM
AzureRT S51 - Include OperationID in CloudException Message
| Properties.Resources.ComputeCloudExceptionOperationIdMessage, | ||
| headers[RequestIdHeaderInResponse].FirstOrDefault()); | ||
| } | ||
| } |
There was a problem hiding this comment.
nit. you can do the same thing with a little bit less code:
var sb = new StringBuilder();
if(!string.IsNullOrEmpty(cloudException.Message))
{
sb.AppendLine(cloudException.Message);
}
if (cloudException.Response != null &&
cloudException.Response.Headers != null)
{
var headers = cloudException.Response.Headers;
if (headers.ContainsKey(RequestIdHeaderInResponse))
{
sb.AppendFormat(
Properties.Resources.ComputeCloudExceptionOperationIdMessage,
headers[RequestIdHeaderInResponse].FirstOrDefault());
}
}
| WriteObject(result); | ||
| } | ||
| if (this.Force.IsPresent | ||
| || this.ShouldContinue(Properties.Resources.AvailabilitySetRemovalConfirmation, |
There was a problem hiding this comment.
please move the OR (||) on the line 55. There are several places with this type of line break. Please change them all.
|
LGTM |
huangpf
changed the title
stankovski
added a commit
that referenced
this pull request
Jul 1, 2015
Show OperationID from CloudException thrown by Compute Cmdlets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.