Skip to content

Load Newtonsoft.Json 10.0.3 side-by-side with 6.0.8 #5599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 1, 2018

Conversation

cormacpayne
Copy link
Member

@cormacpayne cormacpayne commented Feb 21, 2018

Description

Checklist

@blueww
Copy link
Member

blueww commented Feb 22, 2018

@cormacpayne

I have tried the fix with #5457, but:
1.[can resolve by add exception in staticAnalysis] The "Newtonsoft.Json" AssemblyVersionConflict error still repro in StaticAnalysis.
2. [resolved by add back app.config] Following test cases will still fail with 'Newtonsoft.Json‘ version conflict.
Microsoft.WindowsAzure.Management.Storage.Test.Common.Cmdlet.StorageContextDisconnectedTests
It's caused by the 'Newtonsoft.Json‘ version conflict between Commands.Storage.Test and Commands.Common.Authentication. Please help to resolve it. Thanks!

Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wxi file update for the new assembly?

@markcowl markcowl removed their assignment Mar 1, 2018
@markcowl
Copy link
Member

markcowl commented Mar 1, 2018

@cormacpayne cormacpayne merged commit 40a7511 into Azure:preview Mar 1, 2018
@cormacpayne cormacpayne deleted the newtonsoft-load branch May 2, 2018 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants