Skip to content

add breaking change instructions for Get-AzureRmRoleDefinition #5676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2018
Merged

add breaking change instructions for Get-AzureRmRoleDefinition #5676

merged 2 commits into from
Mar 5, 2018

Conversation

darshanhs90
Copy link
Contributor

@darshanhs90 darshanhs90 commented Mar 5, 2018 •
edited
Loading

Description

Checklist

maddieclayton
maddieclayton suggested changes Mar 5, 2018
View reviewed changes
...esourceManager/Resources/Commands.Resources/RoleDefinitions/GetAzureRoleDefinitionCommand.cs Outdated
@@ -48,14 +48,17 @@ public class GetAzureRoleDefinitionCommand : ResourcesBaseCmdlet

[Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, ParameterSetName = ParameterSet.RoleDefinitionName, HelpMessage = "If specified, displays the the roles at and below scope.")]
[Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, ParameterSetName = ParameterSet.RoleDefinitionCustom, HelpMessage = "If specified, displays the the roles at and below scope.")]
[Obsolete("GEt-AzureRmRoleDefinition: The parameter \"AtScopeAndBelow\" is being removed in an upcoming breaking change release.")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change "GEt" to "Get". Is there any migration information for this, or should users just stop using this parameter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this filter isnt supported in the service,in earlier versions it was being ignored.so to make it consistent with the service,we are removing it in the breaking change release

@maddieclayton
Copy link
Contributor

on demand here: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/powershell-demand/553/ (554)

@maddieclayton maddieclayton merged commit d331127 into Azure:preview Mar 5, 2018
@darshanhs90 darshanhs90 mentioned this pull request Apr 16, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maddieclayton maddieclayton maddieclayton approved these changes

Assignees
No one assigned
Labels
Waiting for On Demand
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darshanhs90 @maddieclayton @azuresdkci