Skip to content

NetCore generated conversions #5718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 28, 2018
Merged

Conversation

MiYanni
Copy link
Contributor

@MiYanni MiYanni commented Mar 10, 2018

Description

Generated NetCore projects that build successfully.

Checklist

@MiYanni MiYanni mentioned this pull request Mar 21, 2018
8 tasks
MiYanni added 4 commits March 22, 2018 14:51
…-signed version). Renamed Commands.Storage.Netcore.csproj so it won't conflict with the dataplane project name. Fixed the output path trailing slashes for desktop and paths missing character for netcore.
# Conflicts:
#	Azure.PowerShell.Netcore.sln
Copy link
Member

@cormacpayne cormacpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MiYanni a few minor comments, otherwise LGTM

@@ -226,3 +226,5 @@ Results
Package
.DS_Store
.idea
/src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Logger/bin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MiYanni what are these files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is where the output of the Backup projects build to. Unfortunately, they aren't being covered by some other ignore statement currently, so during testing, I'd have dozens of uncommitted files. So, I'm ignoring them since they shouldn't ever be checked in.

@@ -0,0 +1,53 @@
<Project Sdk="Microsoft.NET.Sdk">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MiYanni any reason that this was the only piece of RecoveryServices that was updated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the only project that built without issue. The other projects all had issues or relied on each other. The logger is completely independent. You can see them (in strike-through) on the list here: #5719

@@ -0,0 +1,133 @@
#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MiYanni I'm not sure if we need to convert this module to .NET Core since it's a preview module

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've converted every module, preview or otherwise, as these projects are intended to be the 'only' projects we'll use at some point in the not-so-distant future. So, in this case, just being thorough.

@cormacpayne
Copy link
Member

List of projects built by this PR: #5738

@cormacpayne cormacpayne merged commit 2e45438 into Azure:preview Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants