Add deprecation messages and fixes for KeyVault #5798
Conversation
There was a problem hiding this comment.
@maddieclayton need to update the upcoming-breaking-changes.md file, otherwise LGTM
| @@ -117,6 +117,11 @@ public static string GetDisplayNameForADObject(string objectId, ActiveDirectoryC | |||
| displayName = servicePrincipal.DisplayName; | |||
| upnOrSpn = servicePrincipal.ServicePrincipalNames.FirstOrDefault(); | |||
| } | |||
| else if (obj.Type.Equals("group", StringComparison.InvariantCultureIgnoreCase)) | |||
There was a problem hiding this comment.
@maddieclayton we should add a change log entry if we want this fix to go out to users before Build
| - The -Parameter parameter has become optional and no longer has a position. | ||
|
|
||
| **Set-AzureKeyVaultCertificateIssuer** | ||
| - The -IssuerProvider has become mandatory. |
There was a problem hiding this comment.
@maddieclayton nit: "the -IssueProvider parameter has become mandatory"
| - The -Certificate parameter has become mandatory. | ||
|
|
||
| **Set-AzureKeyVaultManagedStorageSasDefinition** | ||
| - The -Parameter parameter has become optional and no longer has a position. |
There was a problem hiding this comment.
@maddieclayton nit: we shouldn't need to call out the parameter is now optional, just the positional change
| - The output of this cmdlet has changed from CertificateBundle to PSKeyVaultCertificate. | ||
|
|
||
| **Undo-AzureRmKeyVaultRemoval** | ||
| - ResourceGroupName has been removed from the InputObject parameter set, and is instead obtained from the ResourceId. |
There was a problem hiding this comment.
@maddieclayton nit: "...and is instead obtained from the InputObject parameter's ResourceId property"
|
on demand run here: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/powershell-demand/663/ (and 664) |
| [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>] | ||
| ``` | ||
|
|
||
| ### InputObjectByDeletedVault | ||
| ``` | ||
| Remove-AzureRmKeyVault [-InputObject] <PSKeyVault> [-Location] <String> [-InRemovedState] [-Force] [-AsJob] |
There was a problem hiding this comment.
This parameter is required for recovering a deleted vault.
There was a problem hiding this comment.
So I have just removed this Parameter for the -Input object parameter set because you can actually obtain the location from the PSVault object. It remains in the interactive parameter set above.
|
I should add that the changes look good to me with the exception of removing the Location parameter from the vault recovery cmdlet. |
|
on demand here: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/powershell-demand/687/ (and 688) |
Description
#2243
Deprecation for breaking changes described here: #5496
Checklist
CONTRIBUTING.mdplatyPSmodule