AzureRT PR S51 - Updating Start/Stop Emulator related cmdlets to work with latest .NET release #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
huangpf
commented
Jul 10, 2015
huangpf
commented
- Updated ServiceDefinition and ServiceConfiguration schema files to unblock deserialization
- Updated Version number validation to relax constraint
- Updated StorageEmulator invocation due to StorageEmulator executable rename
|
Hi @huangpf, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
| } | ||
| else if (string.IsNullOrEmpty(version) && key.GetSubKeyNames().Length == 0) | ||
| // select the latest version of SDK installed on the machine. | ||
| version = key.GetSubKeyNames().Last(); |
There was a problem hiding this comment.
It seems, if key.GetSubKeyNames() is empty, Last() would throw exception. Would it be a concern?
There was a problem hiding this comment.
You're right. Let me change that to LastOrDefault() so it won't throw when an item is not found.
|
LGTM. |
hovsepm
pushed a commit
that referenced
this pull request
Jul 10, 2015
AzureRT PR S51 - Updating Start/Stop Emulator related cmdlets to work with latest .NET release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.