New-AzureRmVm/VMSS: verbose parameter output.

[sergey-shandar]

Description

#5650

Known issues:

• It appears that the implementation also depends on the issue New-AzureRmVM/VMSS should use hex or Crockford's Base32 for FQDN #5663. We need deterministic -parameter for a domain name label.
• Complex object PS serialization.
  • IEnumerable
  • null
  • .ToString() for everything else

Checklist

• I have read the Submitting Changes section of CONTRIBUTING.md
• The title of the PR is clear and informative
• The appropriate change log has been updated
• The PR does not introduce breaking changes
• If applicable, the changes made in the PR have proper test coverage
• For public API changes to cmdlets:
  • the changes have gone through a cmdlet design review
  • the cmdlet markdown files were generated using the platyPS module

[praries880]

we should check for null here, what if there is a random class property that does not have any custom attributes... will the code here throw a null ptr exception?

[sergey-shandar]

Type.GetProperties() and PropertyInfo.GetCustomAttributes() never returns null.

• https://msdn.microsoft.com/en-us/library/kyaxdd3x(v=vs.110).aspx
• https://msdn.microsoft.com/en-us/library/kff8s254(v=vs.110).aspx

[praries880]

what about parameters like : https://github.com/praries880/azure-powershell/blob/dependency_fix/src/ResourceManager/Compute/Commands.Compute/VirtualMachine/Operation/GetAzureVMCommand.cs#L64
which do not have the property specified? what happens in this case?

[sergey-shandar]

I've a fix. I'm going to push it soon.

[praries880]

so for this, if the type of the parameter (specifically for custom defined classes) does not implement a ToString() this would just print out the object type instead of a string representation of the data in the object? Do we want to do this?

[sergey-shandar]

Yes, if we don't know the type we use object.ToString() function. This's also default PowerShell behavior.

[praries880]

Want about adding unit tests for this scenario?

[sergey-shandar]

@praries880 I'm going to introduce unit tests in #5972 where the code is used in a generic Strategy library.

[markcowl]

@sergey-shandar As we have discussed, this is an anti-pattern, we should not print additional information based on our own setting of WhatIf - WhatIf should be handled automaticsally by the PowerShell runtime. Additional information printed in WhatIf should use only ShouldProcess prompts.

Verbose output should simply be written to the verbose stream - we cna log such output to the Verbose or Debug streams, depending on the level of information (verbose versus debug/very verbose)

[sergey-shandar]

@markcowl Good catch! I forgot to remove the property. Note: the property was not used anyway, so the behavior is still the same: the cmdlet doesn't relay on the WhatIf parameter.

[markcowl]

on demand run here: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/powershell-demand/764/