-
Notifications
You must be signed in to change notification settings - Fork 4k
Auditing bug fix: Impossible to remove AuditActionGroups when providing AuditActions(And vice versa) #5957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Auditing bug fix: Impossible to remove AuditActionGroups when providing AuditActions (Allow both directions)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ranisha2 Hey Rani, a couple of comments:
- please update the Sql change log to reflect the change being made in this PR
- are we able to add test coverage around this scenario to prevent any future regressions in this functionality?
@ranisha2 ping on the above comments |
@cormacpayne sure will fix and update |
@ranisha2 if this is meant for build, code complete was Monday, this needs to happen today or it will be post-build |
Add test case
@cormacpayne I've updated an existing test. Regarding the change log, Are you going to update the versions? |
@ranisha2 Hey Rani, the only action left for this PR is to update the Sql change log |
Update ChangeLog
Description
Checklist
CONTRIBUTING.md
platyPS
module