Skip to content

Auditing bug fix: Impossible to remove AuditActionGroups when providing AuditActions(And vice versa) #5957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 7, 2018

Conversation

ranisha2
Copy link
Contributor

@ranisha2 ranisha2 commented Apr 15, 2018

Description

Checklist

Auditing bug fix: Impossible to remove AuditActionGroups when providing AuditActions (Allow both directions)
Copy link
Member

@cormacpayne cormacpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ranisha2 Hey Rani, a couple of comments:

  • please update the Sql change log to reflect the change being made in this PR
  • are we able to add test coverage around this scenario to prevent any future regressions in this functionality?

@cormacpayne
Copy link
Member

@ranisha2 ping on the above comments

@ranisha2
Copy link
Contributor Author

@cormacpayne sure will fix and update

@markcowl
Copy link
Member

@ranisha2 if this is meant for build, code complete was Monday, this needs to happen today or it will be post-build

@ranisha2
Copy link
Contributor Author

@cormacpayne I've updated an existing test. Regarding the change log, Are you going to update the versions?
@markcowl It can wait for next release

@cormacpayne
Copy link
Member

@ranisha2 Hey Rani, the only action left for this PR is to update the Sql change log

@cormacpayne cormacpayne merged commit 9729761 into Azure:preview May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants