Enable context autosave by default #6003
Conversation
…tions when logging in with default context set
| @@ -97,6 +97,12 @@ static ContextAutosaveSettings InitializeSessionSettings(IDataStore store, strin | |||
| result.Mode = settings.Mode; | |||
| result.ContextFile = settings.ContextFile ?? result.ContextFile; | |||
| } | |||
| else | |||
| { | |||
| FileUtilities.EnsureDirectoryExists(profileDirectory); | |||
There was a problem hiding this comment.
Note that we still need to be able to switch back to Process mode if there are any errors in writing these files
There was a problem hiding this comment.
@markcowl updated this so it remains Process by default but switches to CurrentUser after we are able to write the settings file
| { | ||
| var tempContext = new AzureContext(subscription, account, environment, newTenant); | ||
| string tempName = null; | ||
| if (!_profile.TryGetContextName(tempContext, out tempName)) |
There was a problem hiding this comment.
Is this using the name of the subcription? I forgot the logic for this
There was a problem hiding this comment.
@markcowl updated the logic for this after discussion so that the name is now {{subscriptionName}} - {{subscriptionId}}
| @@ -227,6 +226,7 @@ public bool TryRemoveContext(IAzureContext context) | |||
| } | |||
| } | |||
|
|
|||
| bool shouldPopulateContextList = _profile.DefaultContext?.Account == null; | |||
There was a problem hiding this comment.
Just in case, we should also ensure that _profile?.Contexts?.Count < 2 (actually, this will need to be two null checks, but you get the idea).
There was a problem hiding this comment.
@markcowl in this class, _profile is of the abstracted type IProfileOperations, which doesn't contain the Contexts property (the implementation AzureRmProfile does contain this property, but I doubt we want to use that in this class). Is there a separate check we can do here?
There was a problem hiding this comment.
makes sense. As long as we are not overwriting existing contexts, I think we are ok here
Description
Fix for issue #5902
Connect-AzureRmAccountwith the default (empty) context, populate the context list with all subscriptions in the current tenantChecklist
CONTRIBUTING.mdplatyPSmodule