Removing explicit parameters for creating KV-managed storage sas definitions #6006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nitions updating help file, with end-to-end example
|
@dragav Please fix the breaking changes errors following the instructions here: https://github.com/Azure/azure-powershell/blob/preview/documentation/Debugging-StaticAnalysis-Errors.md. Please also add a migration guide for this change here: https://github.com/Azure/azure-powershell/blob/preview/src/ResourceManager/KeyVault/documentation/upcoming-breaking-changes.md |
schaabs
reviewed
Apr 20, 2018
| PS C:\> $sa=Get-AzureRmStorageAccount -Name mysa -ResourceGroupName myrg | ||
| PS C:\> $kv=Get-AzureRmKeyVault -VaultName mykv | ||
| PS C:\> Add-AzureKeyVaultManagedStorageAccount -VaultName $kv.VaultName -AccountName $sa.StorageAccountName -AccountResourceId $sa.Id -ActiveKeyName key1 -RegenerationPeriod 180 | ||
| PS C:\> $sctx=New-AzureStorageContext -StorageAccountName $sa.StorageAccountName -Protocol Https -StorageAccountKey Key1 |
There was a problem hiding this comment.
Does running this require access to the actual storage account key? Can users provide a raw "dummy" key such as 00000000?
maddieclayton
approved these changes
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the explicit parameters previously used to compose SAS token definitions for KeyVault-managed storage accounts. These are no longer supported by the service, and have been replaced with the 'templateUri', 'sasType' and 'validityPeriod' parameters, respectively.
Updated the Set-AKVManagedStorageSasDefinition help file, including a working example.
Checklist
CONTRIBUTING.mdplatyPSmodule