Set-AzureRmVmDiskEncryptionExtension makes AAD parameters optional #6040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vermashi
suggested changes
Apr 24, 2018
| @@ -211,8 +252,13 @@ Specifies the client ID of the Azure AD application that has permissions to writ | |||
|
|
|||
| ```yaml | |||
| Type: String | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
You have yet to fix this merge conflict
There was a problem hiding this comment.
resolved ( ejarvi@a761c28 )
vermashi
previously approved these changes
Apr 24, 2018
SudhakaraReddyEvuri-zz
approved these changes
Apr 26, 2018
markcowl
requested changes
Apr 27, 2018
| @@ -592,6 +592,7 @@ public virtual Collection<PSObject> RunPowerShellTest(params string[] scripts) | |||
| d.Add("Microsoft.Features", null); | |||
| d.Add("Microsoft.Authorization", null); | |||
| d.Add("Microsoft.Compute", null); | |||
| d.Add("Microsoft.Azure.Management.KeyVault", null); | |||
There was a problem hiding this comment.
this has no impact, the first parameter is an ARM provider namespace
markcowl
approved these changes
Apr 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes Set-AzureRmVmDiskEncryptionExtension to make AAD parameters optional
design review notes
Checklist
CONTRIBUTING.mdplatyPSmodule