Skip to content

Add US Gov endpoint for OperationalInsights data plane #6058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 27, 2018

Conversation

alexeldeib
Copy link
Contributor

@alexeldeib alexeldeib commented Apr 26, 2018

Description

Checklist

@markcowl
Copy link
Member

@alexeldeib Thanks for the contribution, what is the source of these endpoints? Have you been able to successfuly use operational insights cmdlets in Fairfax using these values?

Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, what is the source of these endpoints? Have you been able to successfuly use operational insights cmdlets in Fairfax using these values?

@alexeldeib
Copy link
Contributor Author

Hey Mark, I'm a dev on the team owning the backend service and i'm also the primary driver on our swagger/SDK/cmdlets. Our Fairfax service endpoint wasn't up while the initial work around SDK/cmdlets was picking up. Now that it's up (and we have users who want to query Fairfax), I figured adding the endpoint (following the existing pattern) would make sense. Users there have already been able to use the cmdlet as-is with a custom Add-AzureRmEnvironment (copying all properties from fairfax, with the addition of our two endpoints), while this bakes that manual workaround into code. I'll admit I haven't extensively tested the cmdlets with this change (fairfax access/perms) -- even so, I figured it was a fairly transparent change to simplify an existing user workflow. Let me know what you think!

@markcowl markcowl changed the base branch from preview to release-6.0.0 April 27, 2018 03:49
@markcowl
Copy link
Member

@maddieclayton
Copy link
Contributor

@azuresdkci test this please

@markcowl markcowl merged commit a3d6899 into Azure:release-6.0.0 Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants